Closed
Bug 201576
Opened 22 years ago
Closed 22 years ago
nsImageWin cleanup
Categories
(Core Graveyard :: GFX: Win32, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: smontagu, Assigned: smontagu)
References
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
smontagu
:
review+
tor
:
superreview+
|
Details | Diff | Splinter Review |
Separating out the "gratuitous style and whitespace changes" from bug 143046 to
make it more reviewable
|
Assignee | |
Comment 1•22 years ago
|
||
|
|
Assignee | |
Comment 2•22 years ago
|
||
|
|
Assignee | |
Updated•22 years ago
|
Attachment #120144 -
Flags: superreview?(tor)
Attachment #120144 -
Flags: review?(paper)
|
||
Comment 3•22 years ago
|
||
Comment on attachment 120144 [details] [diff] [review]
Patch
This looks good, other than that ++y ;)
But that isn't a reason to withhold a review. If you remember, you could
change it to y++ before checkin in. If not, it isn't essential for me.
Attachment #120144 -
Flags: review?(paper) → review+
Comment on attachment 120144 [details] [diff] [review]
Patch
With the removal of CleanUpDIBSection (which incidentally wasn't
removed from the header) it appears that you are leaking mAlphaBits.
Attachment #120144 -
Flags: superreview?(tor) → superreview-
|
|
Assignee | |
Comment 5•22 years ago
|
||
Moved delete of mAlphaBits into the dtor, removed CleanUpDIBSection from the
header and changed ++y back to y++
|
|
Assignee | |
Updated•22 years ago
|
Attachment #120144 -
Attachment is obsolete: true
Attachment #120145 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 6•22 years ago
|
||
Comment on attachment 120477 [details] [diff] [review]
Addressed comments
Transferring r=paper and rerequesting sr.
Attachment #120477 -
Flags: superreview?(tor)
Attachment #120477 -
Flags: review+
Attachment #120477 -
Flags: superreview?(tor) → superreview+
|
|
Assignee | |
Comment 7•22 years ago
|
||
Fix checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•