Closed Bug 20159 Opened 25 years ago Closed 23 years ago

Cannot tab between links on some sites

Categories

(Core :: DOM: UI Events & Focus Handling, defect, P3)

defect

Tracking

()

VERIFIED WORKSFORME
Future

People

(Reporter: bugzilla, Assigned: alexsavulov)

References

Details

(Keywords: polish, Whiteboard: [nsbeta3-])

I really woruld like that Mozilla could have the tab-to-a-link feature that IE/Microsoft has. That's a great thing for people with disabilities!
Assignee: troy → pollmann
I don't know if this is an event think or a form element/link feature
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → WORKSFORME
This feature is already implemented. Try one of the latest builds - thanks!
Status: RESOLVED → VERIFIED
In the Dec 01 builds, tabbing between the links on a page is working.
This doesn't work anymore. Build 2000040415
Status: VERIFIED → REOPENED
Resolution: WORKSFORME → ---
This works for me in the same build. I know of one remaining issue: bug 20322 - Fields don't erase their border when loose focus Marking as WORKSFORME. If you would like to reopen this bug include 1) Platform you tested on. 2) URL of the page you did not see it working on 3) Action you took 4) What you saw Thanks!
Status: REOPENED → RESOLVED
Closed: 25 years ago25 years ago
Resolution: --- → WORKSFORME
I go to www.mozilla.org and the press TAB a couple of times and I cant see that the focus changes from link to link. Build 2000040508 on Win2K
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
I am also able to reproduce this on NT 4.0. The problem appears to be that unless a form element has focus, clicking tab will not advance focus along to the first item and so forth. But once something has focus, there is no problem. CC'ing Tom as this may be a more general focus manager problem. CC'ing Chris as it may be a problem he's familiar with. Moving to M17 as this is a medium/major usability issue.
Status: REOPENED → ASSIGNED
Component: Layout → Event Handling
Target Milestone: --- → M17
add saari and hyatt, focus gods.
I think tabbing between links works right now, we just don't have any visual feedback that a link is the focused item.
On http://www.mozilla.org, tabbing repeatedly does not scroll elements further down the page into view as it would if they were being given focus. (On http://bugzilla.mozilla.org, tabbing repeatedly does eventually scroll off-screen links into focus). Pressing Enter will follow a link when it has focus, even if the display isn't correctly updated. That does not work on www.mozilla.org but does work on bugzilla.mozilla.org after you tab past the text input and button. Style is set to draw an outline around the link in html.css: :link:focus, :visited:focus, :out-of-date:focus, :link:focus img, :visited:focus img, :out-of-date:focus img { outline: 1px dotted black; } This used to work but isn't any longer. Are any of you working on this issue already as a separate bug that this is a duplicate of? Thanks!
just a note: i had to vote for this one because today my wrist is injured and i need this TAB key navigation feature badly in order not to use the mouse...
When I tab out of the "Address" bar up top, I have NO IDEA where the focus ends up. No cursor anywhere until I click into something.. I haven't seen tabbing between links work at all yet.. Windows 2000, M16 and 6/21/2000 nightly builds.. The way IE5 does it is pretty slick.. If you tab out of the address bar, it takes you to the next link after the place you most recently clicked in the page.
Wilson : «I haven't seen tabbing between links work at all yet» it used to work (until M13 or so), this is a regression. shouldn't it be tagged as a regression in the report subject or wherever ? btw, my wrist is broken, i really wish tabbing could work :(
Yes, I'm also seeing it not work in recent builds
Hardware: PC → All
Summary: Tab between links → Cannot tab between links
Target Milestone: M17 → M18
This *should* work, see: nsEventStateManager::GetNextTabbableContent around line 1933: else if(nsHTMLAtoms::a==tag.get()) { I think this is where the check is done...
Oops, the test case I was seeing it not work on was here: http://bugzilla.mozilla.org/showattachment.cgi?attach_id=7218 And that doesn't work because the <a> has no href and I have a fix in my tree for that. (or did I already check that in?) Anyway, it *does* still work on bugzilla.mozilla.org. To verify, this, click on the text input. Press tab a few times. You'll notice that the page starts being scrolled down to show links. There is still no visual feedback that the links have received focus, and no way to tab straight from the URL bar down into the links within document. Since this never worked, removing the regression keyword... Next, why isn't tabbing between links working on www.mozilla.org?
Keywords: regression
It's ugly, but functional - if I change this rule in html.css: :link:focus, :visited:focus, :out-of-date:focus, :link:focus img, :visited:focus img, :out-of-date:focus img { outline: 1px dotted black; } to: :link:focus, :visited:focus, :out-of-date:focus, :link:focus img, :visited:focus img, :out-of-date:focus img { border: 1px dotted black; } we suddenly get indication that links are receiving focus. outline isn't used anywhere else in html.css, is it not working? Should we fix that instead?
Tabbing through links works fine on www.mozilla.org, if you first mouse down on one (but mouse up somewhere else so as not to trigger the link). If you don't do that first, I see the same thing that I see when pressing tab from the URL bar: in nsEventStateManager::GetNextTabbableContent, the enumeration (assuming this is a frame tree) returned by NS_NewFrameTraversal does not return any frames when frameTraversal->Next is called. Thus we just fail out before even walking the frame tree looking for tabbable content.
'outline' is dead for FCS.
Eric: to complete Ian's comments... 'outline' is so poorly supported in current builds that it will soon be disabled. See bug 9816.
Marking nsbeta3-
Whiteboard: [nsbeta3-]
Moving bug marked nsbeta3- to Future milestone.
Target Milestone: M18 → Future
outline's back ! i can see the outline again on links when i use TAB in linux build 2000-08-24-08-M18. but you still have to click in the window one time first to make it work...
Maybe it looks like an outline but it cannot be an outline in the CSS sense because I disabled them earlier this month (bug 9816).
It is a -moz-outline - Rod S. enabled it for links and form controls to use to show focus (note that it also draws on the inside of the border, not the outside).
It looks like this bug is getting a bit confused. What Gemal had a requesed was for us to impliment "tabbing" through links only this means skipping the form controls and buttons. This is something above and beyond tabbing to the next item as Tab should work. Though Tabbing to the next item meeds to work as well this was not what the reporter was asking for. Pressing tab and tab order is addressed in bug 51424 for NSBeta3. I will be opening a separate bug for Post Beta3
i think this bug could be closed. using a 2000101708 Mtrunk build i can type the url in the url bar, then hit enter and then use tab so that the focus goes from one link to another. so i assume "tabbing" works now, doesn't it ?
Okay, seems to be somewhat working for me too - though I don't think that all the kinks are worked out. For example, if I click on the URL bar after a page is loaded and press tab, we do not begin focusing links in the document. Also, there is a recent regressions in that if you tab through a long document (e.g. this bug report, www.mozilla.org), eventually tabbing through links will just stop and refuse to go further. Shift+tab will let you go back, but you can't go forward. CC'ing Ben - if you're already working on these issues we should probably close this old, probably wrongly-assigned bug out.
Is this bug still an rfe for tabbing between only links? Is there another bug asking for tabbing through only form elements?
At the time the bug was reported, I think that tab was not shifting focus at all (or rather, there was no UI that indicated focus was shifting). I don't see any mention of only tabbing to links in the initial report, which was rather terse, and have also not heard any recommendations for a UI for such a feature (what key combination would do this?). I've just been treating it as the general "Tab doesn't shift focus" bug - if there are other issues, such as tabbing between only links or only form elements, other bugs should probably be filed.
Adding dependencies: bug 54406 (get stuck: <a> containing <br> or soft linebreak (www.mozilla.org)) bug 64633 (get stuck: <table><table><a><img>?)
Depends on: 54406, 64633
Summary: Cannot tab between links → Cannot tab between links on some sites
No longer depends on: 64633
Depends on: 51680
The dependencies I added recently have been fixed. Bug 66285 would be a good place to discuss being able to tab *only* to links, if anyone wants that ability. I think this bug should be resolved now (as fixed).
Bulk reassigning form bugs to Alex
Assignee: pollmann → alexsavulov
Status: ASSIGNED → NEW
this all seems to be fine now. File new bugs for specific outstanding issues. Marking WFM.
Status: NEW → RESOLVED
Closed: 25 years ago23 years ago
Resolution: --- → WORKSFORME
v 20020222
Status: RESOLVED → VERIFIED
Component: Event Handling → User events and focus handling
You need to log in before you can comment on or make changes to this bug.