Closed Bug 202218 Opened 22 years ago Closed 19 years ago

[beos] customize toolbar window displays titlebar

Categories

(Firefox :: Toolbars and Customization, defect)

x86
BeOS
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: beos, Unassigned)

References

Details

(Keywords: helpwanted)

I have a patch prepared for the BeOS widget library, that makes nsWindow under BeOS honor the eBorderStyle attributes of a window. I wrote the patch, in the hopes that the "Customize Toolbar" window would be created w/o the title bar. However, the title bar remains. The eBorderStyle that is passed into the nsWindow's create method is eBorderStyle_all, so, even with my patch applied, the window still has a titlebar. I've searched for where and why this is happenning, but, I'm having trouble finding the solution.
Keywords: helpwanted
Some addition comments: Is it the intension of Phoenix that eWindowType_dialog has no titlebar, is not resizable, etc.? The reason I ask, is that the "Customize Toolbar" window is created as a dialog, and, with a border style of eWindowStyle_default, which is, according to nsIWidget.h: // whatever the OS wants... i.e. don't do anything eBorderStyle_default = -1 But, obviously, that is not what I suspect is suposed to happen. So, shouldn't the border style for the custimize toolbar dialog be eBorderStyle_none instead? If so, where would this be defined?
Setting to major, as, IMO, the customize toolbar item is fairly significant in Firebird, and, with the way things work now, not only is it ugly, but completely wrong. Setting P1, since I would like to get this fixed ASAP.
Severity: normal → major
Priority: -- → P1
Taking QA Contact
QA Contact: asa → bugzilla
not major severity, please don't set priority on bugs, that is a assignee-set flag
Severity: major → normal
Priority: P1 → --
The customize toolbar window actually appears to use the function HideWindowChrome. You need to implement this function on BeOS.
/* Hide window chrome (borders, buttons) for this widget. */ Which means we should override it and change style of the window where there is one. Should be easy to do.
Blocks: 266252
Implementing HideWindowChrome doesn't seem to do that. Maybe that's called in a specific OS implementation?
Assignee: hyatt → nobody
QA Contact: bugzilla → toolbars
No longer blocks: 266252
Blocks: 311032
tqh, in our case it needs changing BWindow look, did you try to do it?
Fixed by bug 296856.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.