Build: 2003-04-28-03 Platform: OS X 10.2.5 Expected Results: The window's toolbar should become hidden after clicking on the the window's toolbar button (located in upper right corner of window) What I got: Toolbar remains displayed Steps to reproduce: 1) Open the Manage bookmarks window 2) Click on toolbar button 3) The windows toolbar is still visible and really should be hidden 4) The Toolbar button is supported in both the browser window and dl manager window. So it should also work in the manage bookmarks window.

confirming, I can reproduce it too

I have no MacOSX build, but one should not set the hidden attribute to 'false'. This patch simplifies goToggleToolbar and uses properties instead of attributes. It fixes for sure a bug: with a fresh profile, the menuitem (that toggles the toolbar) is not checked when the bookmark manager appear for the first time. Jan or Chris, could you test if this patch solves the reported problem? (I doubt, but who knows...)

aheum, I didn't read the bug report carefully. I thought you were speaking of the Toolbar menuitem in the View menu. What's that toolbar button on the upper right corner of the bookmark manager window? is it the MacOSX grippy incarnation?

That toolbar button is specific only to MacOSX (the button is handled by window manager) and it hides the toolbox completely.

-> me

also confirmed on Firefox 1.0PR RC Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; rv:1.7.3) Gecko/20040911 Firefox/0.10

So, should just the toolbar with the buttons be hidden or should even the search field (with its search button) be hidden?

This will hide both toolbars when hitting the collapse toolbar button.

Comment on attachment 179484 [details] [diff] [review] Make collapsible toolbar widget work >+ <toolbar class="chromeclass-toolbar" id="command-toolbar" tbalign="stretch" >+ grippytooltiptext="&bookmarkToolbar.tooltip;"> Nit: line these attributes up with the previous line, not the next line :-P marksSearch.tooltip;"> >+ <toolbar class="chromeclass-toolbar" id="bookmarks-search" >+ grippytooltiptext="&bookmarksSearch.tooltip;">

Comment on attachment 179484 [details] [diff] [review] Make collapsible toolbar widget work I don't think we should hide the toolbar, from the user POV, this isn't a toolbar, it's a standalone search field (which woudn't get hidden in the the messanger for exmaple).

err, s/toolbar/search toolbar

FTI, the firefox bug was bug 278649.

This will only hide the "real" toolbar.

Comment on attachment 179594 [details] [diff] [review] New version that only hides the toolbar (Checked in) Checking in bookmarksManager.xul; /cvsroot/mozilla/xpfe/components/bookmarks/resources/bookmarksManager.xul,v <-- bookmarksManager.xul new revision: 1.8; previous revision: 1.7 done

--> Fixed