Closed
Bug 20383
Opened 25 years ago
Closed 24 years ago
showattachment.cgi does not return filename
Categories
(Bugzilla :: Attachments & Requests, defect, P3)
Tracking
()
People
(Reporter: jasonab, Assigned: justdave)
References
Details
(Whiteboard: 2.16)
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
When attempting to view or download an attachment, showattachment.cgi does not
return a filename, and instead returns its own name. This complicates matters
inordinantly when trying to save an attachment to disk, as you have no idea what
sort of file you are downloading, or what it should be called.
Updated•25 years ago
|
Status: NEW → ASSIGNED
Comment 1•25 years ago
|
||
Comment 2•25 years ago
|
||
The submitted patch uses an HTTP 1.1 header that Netscape and IE implement to
return the filename with the download. This does not affect text attachments,
however, and their name is still a cgi string.
Comment 3•25 years ago
|
||
Regarding "Remove any path information stored in the database"
in the attachment of 2000-02-07,
the regexp /[^\\]+$/ assumes Windows pathnames.
To handle both Windows and Unix pathnames, try m{[^/\\]+$} .
Comment 4•25 years ago
|
||
References of possible interest:
ftp://ftp.isi.edu/in-notes/rfc2616.txt, section 19.5.1
http://andrew2.andrew.cmu.edu/rfc/rfc1806.html
bug 6519
bug 27248
Comment 5•25 years ago
|
||
tara@tequilarista.org is the new owner of Bugzilla and Bonsai. (For details,
see my posting in netscape.public.mozilla.webtools,
news://news.mozilla.org/38F5D90D.F40E8C1A%40geocast.com .)
Assignee: terry → tara
Status: ASSIGNED → NEW
Updated•24 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 6•24 years ago
|
||
This bug has a patch on it waiting to get checked in...
Assignee | ||
Comment 7•24 years ago
|
||
Ah, but the patch is incomplete - assumes it's running on Windows. but it's a
three character change to get it running on both Windows and Linux and the change
is described in an earlier comment here.
Assignee | ||
Comment 9•24 years ago
|
||
Point of interest.... according to bug 6519, this functionality used to be in
Bugzilla, and was removed on purpose because it broke the XML filetype.
What I would suggest here is that if this is put in, that it be conditional, and
only add the name parameter if the file is known to be binary (since it's ignored
on text, and breaks XML)
Updated•24 years ago
|
Whiteboard: 2.14
Updated•24 years ago
|
Whiteboard: 2.14 → 2.16
Comment 11•24 years ago
|
||
Adding default QA contact to all open Webtools/Bugzilla bugs lacking one.
Sorry for the spam.
QA Contact: matty
Assignee | ||
Comment 12•24 years ago
|
||
moving to real milestones...
Target Milestone: --- → Bugzilla 2.16
Comment 13•24 years ago
|
||
There is another bug about this subject which also has a patch attached, but
it looks more elaborated to me (and is in diff -u format), so I'm marking this
as a duplicate.
*** This bug has been marked as a duplicate of 63601 ***
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → DUPLICATE
Assignee | ||
Comment 15•23 years ago
|
||
moving all closed Bugzilla bugs to the new Bugzilla product.
This batch is DUPLICATE/INVALID/WORKSFORME/WONTFIX
reassigning to default owner and QA in case of the bug being reopened.
Clearing milestones, since we really shouldn't have them on these types of
resolutions. Sorry for the spam everyone...
Assignee: Chris.Yeh → justdave
Status: VERIFIED → NEW
Component: Bugzilla → Bugzilla-General
Product: Webtools → Bugzilla
Target Milestone: Bugzilla 2.16 → ---
Version: other → unspecified
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•