Closed
Bug 20496
Opened 25 years ago
Closed 25 years ago
[REGRESSION] Navigation Toolbar appears bad
Categories
(Core :: Layout, defect, P3)
Tracking
()
VERIFIED
FIXED
M16
People
(Reporter: shrir, Assigned: pavlov)
References
Details
(Keywords: regression)
Attachments
(3 files)
(deleted),
image/gif
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
Using today's commercial build on Linux located at:
ftp://sweetlou/products/client/seamonkey/unix/linux/2.2/x86/1999-12-01-09-M12/ne
tscape-i686-pc-linux-gnu.tar.gz
Try the following:
Install and launch the browser.
Upon launch, observe that the Navigation toolbar appears dull and wiped off.
Similar to http://bugzilla.mozilla.org/show_bug.cgi?id=17245
Updated•25 years ago
|
Assignee: trudelle → don
Comment 1•25 years ago
|
||
Mail, Compose and IM toolbars are fine. reassigning to don
Comment 2•25 years ago
|
||
...and yes this is Linux only.
Assignee: don → slamm
Priority: P3 → P2
Summary: Navigation Toolbar appears bad → [DOGFOOD][REGRESSION] Navigation Toolbar appears bad
Target Milestone: M12
Steve, can you reproduce this? (I don't have a copy of today's Linux build at
home.)
Comment 5•25 years ago
|
||
everyone is seeing this on linux, mozilla bits as well.
Comment 6•25 years ago
|
||
Comment 8•25 years ago
|
||
leger: look at my screenshot, attached :-)
Assignee | ||
Comment 9•25 years ago
|
||
i don't see this :(
Comment 10•25 years ago
|
||
I see it with a build from last night. Actually it's a lot more colorful than
Chris' screenshot. :-) Re-building now to see if the problem still exists ...
Comment 11•25 years ago
|
||
problem is still here, and looks different every time I start the app.
Comment 12•25 years ago
|
||
I see it too. And the garbage displayed in there changes as I navigate to
different pages.
Comment 13•25 years ago
|
||
But you're functional...Putting on PDT- radar.
Updated•25 years ago
|
Assignee: slamm → pavlov
Comment 14•25 years ago
|
||
something special about pavlov's display works,
solaris/slamm's/akkana's/my displays show this problem.
Pavlov has a special Xserver.?
Assignee | ||
Comment 15•25 years ago
|
||
actually its not working here either.. my xserver is just filling in the undrawn
area with black so it was hard to notice. if you make the image's
(navbar-bg.gif) width some number bigger than 5 (like 6) (it is currently 1) it
will be fine.
Assignee | ||
Comment 16•25 years ago
|
||
don, your checkin to nsCSSRendering.cpp to fix 16685 caused this one. We should
always be setting the clip rect/region of something before we draw to a
rendering context.
Comment 17•25 years ago
|
||
That comment in that bug was mis-leading. I took out the extra clipping I was
doing when I was tiling to the screen.. There is a clip present on the
RenderingContext, I just took out the extra clip that used to be there.
The clip I took out is commented out so you can see exaclty where I did this
change, ~line 2120 in nsCSSRenderingContext.cpp is where I made the change. I
don't think this caused the problem, or if it did it is revealing another
problem somewere else.
Comment 18•25 years ago
|
||
*** Bug 20715 has been marked as a duplicate of this bug. ***
Comment 19•25 years ago
|
||
*** Bug 20787 has been marked as a duplicate of this bug. ***
Comment 20•25 years ago
|
||
*** Bug 20903 has been marked as a duplicate of this bug. ***
Updated•25 years ago
|
Priority: P2 → P3
Target Milestone: M12 → M13
Comment 21•25 years ago
|
||
setting p3 for m13 to get off m12 radar. Slamm, why did you assign this to Pav?
It seems app-specific, since other toolbars work fine.
Assignee | ||
Comment 22•25 years ago
|
||
don, backing out your change to that setcliprect fixes the problem. i don't
know whats up...
Updated•25 years ago
|
Target Milestone: M13 → M12
Comment 23•25 years ago
|
||
trudelle: the problem is the background image of the nav bar, which is only used
there, that's why it's only showing up on one toolbar.
m13? Take the damned background out, back to m12 for workaround.
PDT-, huh?
Comment 24•25 years ago
|
||
Talked with pavlov, he's gonna get with dcone about this tomorrow
and try and get a fix or a workaround.
Updated•25 years ago
|
Target Milestone: M12 → M13
Comment 25•25 years ago
|
||
McAfee: I don't care how easy this is to fix, it is not required for M12. Please
do not retarget my team's bugs.
Pavlov, this is not something that you should be spending time on, especially
in the last 24 hours before a deadline. If someone who doesn't have PDT+ bugs
wants to remove it, fine.
Moving to M13, for the third time, and I expect it to stay there.
Comment 26•25 years ago
|
||
This is an ugly regression. Why is this pushed out to M13? Sure it does not
change the function of the browser, but it looks terrible. Even if there are
other functional problems, this should receive priority since it forms the first
impression of the browser.
Comment 27•25 years ago
|
||
I have a workaround fix ready to go, we pull the background image
and change the toolbar color. 10 min. of work. dcone is testing
the real fix, I suggest we take one of these fixes ASAP.
Comment 28•25 years ago
|
||
Assignee | ||
Updated•25 years ago
|
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 29•25 years ago
|
||
fixed.
Comment 30•25 years ago
|
||
Looks great!
Comment 31•25 years ago
|
||
*** Bug 21663 has been marked as a duplicate of this bug. ***
Comment 32•25 years ago
|
||
*** Bug 21790 has been marked as a duplicate of this bug. ***
Comment 33•25 years ago
|
||
*** Bug 20526 has been marked as a duplicate of this bug. ***
Updated•25 years ago
|
Status: RESOLVED → VERIFIED
Comment 34•25 years ago
|
||
fixed long ago...., marking VERIFIED
Reporter | ||
Comment 35•25 years ago
|
||
Reopening bug. Seeing this on today's commercial build on Linux for M14
(2000012609).
Status: VERIFIED → REOPENED
Reporter | ||
Updated•25 years ago
|
Target Milestone: M13 → M14
Assignee | ||
Comment 37•25 years ago
|
||
*** Bug 25126 has been marked as a duplicate of this bug. ***
Comment 38•25 years ago
|
||
*** Bug 25768 has been marked as a duplicate of this bug. ***
Assignee | ||
Updated•25 years ago
|
Comment 39•25 years ago
|
||
*** Bug 26284 has been marked as a duplicate of this bug. ***
Comment 40•25 years ago
|
||
*** Bug 26284 has been marked as a duplicate of this bug. ***
Comment 42•25 years ago
|
||
So is this supposed to be PDT+ dogfood or beta1? There is no comment. This is
not preventing anyone from using the product, or even hindering their use of the
product, so I'm hoping that it is beta1.
Assignee | ||
Comment 43•25 years ago
|
||
beta1 i hope.
Comment 44•25 years ago
|
||
I hope that this bug gets fixed as soon as possible, because in my mind, this is
certainly is hampering people's use of mozilla. I mean, come on! Say for
example, someone who has been waiting out on mozilla hears that it is finally
alpha. "Great," they think," maybe it's starting to become the browser I've
been hearing about!" So they download it, un-tar it, load it, and what's the
first thing they see? Garbage strewn up and down the toolbar, and as a result, a
browser that looks like a super-buggy piece of ****. Yes, this is certainly
"hindering their use of the product."
Comment 45•25 years ago
|
||
Yes, PDT+ for beta1.
Comment 46•25 years ago
|
||
*** Bug 26414 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 48•25 years ago
|
||
fixed.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
Comment 49•25 years ago
|
||
Today I downloaded debian's m13 build, from jan 26 -- it exhibited the
corruption, when debian's m12 build from mid december does NOT show the
corruption. I do hope that it is fixed; it was hard to convince friends that
mozilla was a good web browser when it looked so blasted ugly... :)
Thanks :)
Comment 50•25 years ago
|
||
looks fixed in the 2000020708 Linux RH6 builds. lets hope it stays that way this time. Marking VERIFIED.
Status: RESOLVED → VERIFIED
Comment 51•25 years ago
|
||
*** Bug 27448 has been marked as a duplicate of this bug. ***
Comment 52•25 years ago
|
||
*** Bug 27370 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 53•25 years ago
|
||
Reopening. Seing this on today's linux commercial build (2000042409).
Comment 54•25 years ago
|
||
I think this is because I put my changes in for Tileing to happen in the
RenderingContext.. and in the nsRenderingContextImpl::DrawTile method.. the
#ifdef for XP_UNIX is not there. If you add this.. I think this problem will go
away. Just a temporary solution until you get your other tiling code working.
Updated•25 years ago
|
Keywords: regression
Assignee | ||
Comment 55•25 years ago
|
||
*** Bug 37048 has been marked as a duplicate of this bug. ***
Comment 56•25 years ago
|
||
when preferences is now loaded and i select fonts, i also observe that the
heading there actually "animates" the garble while the content of boxes are
loaded in. Indicates that a lot of probably unwanted refreshes of the titlebar
in prefs are going on, for some reason.
Comment 57•25 years ago
|
||
*** Bug 37236 has been marked as a duplicate of this bug. ***
Comment 58•25 years ago
|
||
dcone -
If this is "because I put my changes in for Tileing to happen in the
RenderingContext.." then you broke unix. you should either back out your change
or fix unix.
Assignee | ||
Comment 59•25 years ago
|
||
reassigning to dcone. don, could you please check in the fix for this?
Assignee: pavlov → dcone
Status: REOPENED → NEW
Component: XP Toolkit/Widgets → Layout
Comment 60•25 years ago
|
||
Comment 61•25 years ago
|
||
The fix was a platform specific fix in cross platform code. I thought Pavlov
had a fix for the GTK platform.. so my comment was mearly a heads up that if you
had your fast tiler working.. this bandage (#ifdef XP_UNIX ) did not need to get
in. If you were going to be a few days longer.. then put the #ifdef back in
until it worked. I will fix it.. but its just a bandage..and will have to be
taken out when Pav has his stuff working.
Status: NEW → ASSIGNED
Comment 62•25 years ago
|
||
above patch seems to fix the problem (band-aid wise). there a re a few glitches
at the right end of the tolbar, but windows seems to have them as well so they
must either be generic tiler issuesor XUL/CSS issues).
Comment 63•25 years ago
|
||
I think that's just some lame XUL - nice patch puetzk!
Comment 65•25 years ago
|
||
Putting on nsbeta+ radar. but this is so bad, PDT can we get a dogfood
consideration?
Comment 66•25 years ago
|
||
this will be fixed today... I will put the bandage back in.. I have been doing
other things to nsRenderingContextImpl that prevented the temporary fix.. but
it is now ready to go in as soon as the tree opens...
Assignee | ||
Comment 68•25 years ago
|
||
checked in patch.
Status: NEW → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
Comment 69•25 years ago
|
||
Thanks Stuart.. beat my checkin by a few minutes..
Let me know when your tiling stuff is finished and I will take out this
patch....
Comment 70•25 years ago
|
||
*** Bug 37533 has been marked as a duplicate of this bug. ***
You need to log in
before you can comment on or make changes to this bug.
Description
•