Closed
Bug 205260
Opened 22 years ago
Closed 22 years ago
Warnings in CTL
Categories
(Core :: Layout: Text and Fonts, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 203406
People
(Reporter: timeless, Assigned: prabhat.hegde)
References
Details
Attachments
(1 obsolete file)
I didn't fix every warning from CTL, but this bug is to clean up the easy ones: /swap/BEOS/mozilla/intl/ctl/src/nsULE.cpp: In method `nsresult nsULE::GetPresentationForm(const PRUnichar *, uns igned int, const char *, char *, PRSize *)': /swap/BEOS/mozilla/intl/ctl/src/nsULE.cpp:208: warning: comparison between signed and unsigned /swap/BEOS/mozilla/intl/ctl/src/nsULE.cpp: In method `nsresult nsULE::NextCluster(const PRUnichar *, unsigned in t, int, PRInt32 *)': swap/BEOS/mozilla/intl/ctl/src/nsULE.cpp:300: warning: control reaches end of non-void function `nsULE::NextClu ster(const PRUnichar *, unsigned int, int, PRInt32 *)' /swap/BEOS/mozilla/intl/ctl/src/nsULE.cpp: In method `nsresult nsULE::PrevCluster(const PRUnichar *, unsigned in t, int, PRInt32 *)': /swap/BEOS/mozilla/intl/ctl/src/nsULE.cpp:393: warning: control reaches end of non-void function `nsULE::PrevClu ster(const PRUnichar *, unsigned int, int, PRInt32 *)' /swap/BEOS/mozilla/intl/ctl/src/nsULE.cpp: In method `nsresult nsULE::GetRangeOfCluster(const PRUnichar *, unsig ned int, int, PRInt32 *, PRInt32 *)': /swap/BEOS/mozilla/intl/ctl/src/nsULE.cpp:466: warning: control reaches end of non-void function `nsULE::GetRang eOfCluster(const PRUnichar *, unsigned int, int, PRInt32 *, PRInt32 *)' /swap/BEOS/mozilla/intl/ctl/src/nsUnicodeToSunIndic.cpp: In method `nsresult nsUnicodeToSunIndic::Convert(const PRUnichar *, PRInt32 *, char *, PRInt32 *)': /swap/BEOS/mozilla/intl/ctl/src/nsUnicodeToSunIndic.cpp:159: warning: unused variable `nsresult res'
Attachment #122976 -
Flags: superreview?(tor)
Attachment #122976 -
Flags: review?(prabhat.hegde)
Assignee | ||
Comment 2•22 years ago
|
||
Thanks for the patch. Actually i have a patch pending review that fixes most of this and other problems. Jumbo Patch 123137 now incorporates your fixes. (http://bugzilla.mozilla.org/attachment.cgi?id=123137&action=view)
Assignee: timeless → prabhat.hegde
Depends on: 203406
*** This bug has been marked as a duplicate of 203406 ***
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → DUPLICATE
Attachment #122976 -
Attachment is obsolete: true
Attachment #122976 -
Flags: superreview?(tor)
Attachment #122976 -
Flags: review?(prabhat.hegde)
Component: Layout: CTL → Layout: Text
QA Contact: arthit → layout.fonts-and-text
You need to log in
before you can comment on or make changes to this bug.
Description
•