Closed
Bug 207403
Opened 22 years ago
Closed 21 years ago
URLs in the js console are not formatted like a link (blue, underlined) anymore
Categories
(Toolkit Graveyard :: Error Console, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.7.4
People
(Reporter: steffen.wilberg, Assigned: steffen.wilberg)
References
()
Details
(Keywords: regression, Whiteboard: fixed-aviary1.0)
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030526 Mozilla Firebird/0.6 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030526 Mozilla Firebird/0.6 URLs in the js console are not formatted like a link. Reproducible: Always Steps to Reproduce: 1. Open Javascript console. 2. Look for a link in it. If you can't find one, browse to http://java.sun.com/getjava/ Actual Results: The url in the js console is not formatted like a link, e.g. blue and underlined. Expected Results: The url should be formatted like a link so that you know where to click on (not on Source File, not on Line #). Mozilla does this right.
Confirmed using Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.4b) Gecko/20030529 Mozilla Firebird/0.6 => change status to "New" since I didn't find a related, already existing bug Note: I don't get a JS error when visiting java.cun.com - perhaps one has to use a different page...
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 2•21 years ago
|
||
Problem still exists in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030726 Mozilla Firebird/0.6.1 Use http://www.javascriptkit.com/javatutors/errortest.htm for testing, which should remain permanently erroneous.
Assignee | ||
Updated•21 years ago
|
Updated•21 years ago
|
QA Contact: asa
I am experencing this bug with FireFox 0.8 Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040206 Firefox/0.8
Updated•21 years ago
|
Priority: -- → P3
Target Milestone: --- → Firefox1.0beta
Comment 4•21 years ago
|
||
chrome://global/content/console.xul needs to reference chrome://commmunicator/skin/formatting.css - then all will be well : )
Assignee | ||
Comment 5•21 years ago
|
||
Thanks for the tip. But we're not using chrome://commmunicator/skin/formatting.css anywhere in Firefox, so I'd suggest to add the rules we need to console/skin/console.css.
OS: Windows XP → All
Hardware: PC → All
Assignee | ||
Comment 6•21 years ago
|
||
I've left out some rules that don't work: .text-link:focus { color:red } .text-link:hover:active { color: red } .text-link[visited="true"] { color: purple }
Assignee | ||
Updated•21 years ago
|
Assignee: firefox → steffen.wilberg
Status: NEW → ASSIGNED
Assignee | ||
Updated•21 years ago
|
Attachment #144317 -
Flags: review?(bugs)
Comment 7•21 years ago
|
||
marking fixed. I just saw that there was a patch in here. Some time wasted. I put the rules in the toolkit formatting.css file. class text-link can be useful.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•21 years ago
|
||
Comment on attachment 144317 [details] [diff] [review] patch: add rules to console/skin/console.css Fixed by pch.
Attachment #144317 -
Attachment is obsolete: true
Attachment #144317 -
Flags: review?(bugs)
Assignee | ||
Updated•21 years ago
|
Target Milestone: Firefox1.0beta → Firefox0.9
Comment 9•21 years ago
|
||
Did this patch cause the link in the page info blue and the context menu to it underlined?
Assignee | ||
Comment 10•21 years ago
|
||
(In reply to comment #9) > Did this patch cause the link in the page info blue and the context menu to it > underlined? Yes and no. It wasn't my patch, but pch's checkin for this bug: http://bonsai.mozilla.org/cvsquery.cgi?date=explicit&mindate=03%2F20%2F2004+00%3A01&maxdate=03%2F20%2F2004+00%3A01 See bug 238186.
Assignee | ||
Comment 11•21 years ago
|
||
Broken again with the new Winstripe theme. -> Reopening, at least for Windows.
Status: RESOLVED → REOPENED
OS: All → Windows XP
Hardware: All → PC
Resolution: FIXED → ---
Target Milestone: Firefox0.9 → ---
Assignee | ||
Updated•21 years ago
|
Attachment #144462 -
Attachment is obsolete: true
Assignee | ||
Updated•21 years ago
|
Keywords: regression
Assignee | ||
Updated•21 years ago
|
Summary: URLs in the js console should be formatted like a link (blue, underlined) → URLs in the js console are not formatted like a link (blue, underlined) anymore
Target Milestone: --- → Firefox0.9
Assignee | ||
Comment 12•21 years ago
|
||
pch said in comment 7: "I put the rules in the toolkit formatting.css file. class text-link can be useful." This patch puts them back there. It has no effect to page info (bug 238186). Another option is to put these in toolkit/themes/winstripe/global/console.css, but I agree with pch that these rules can be useful.
Assignee | ||
Comment 13•21 years ago
|
||
Comment on attachment 150378 [details] [diff] [review] fix it again Mike, this is a regression fix for 0.9.
Attachment #150378 -
Flags: review?(mconnor)
Comment 15•21 years ago
|
||
Comment on attachment 150378 [details] [diff] [review] fix it again blech, this old chestnut? :)
Attachment #150378 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 16•21 years ago
|
||
-> js console.
Component: General → JavaScript Console
QA Contact: firefox.js-console
Assignee | ||
Updated•21 years ago
|
Status: REOPENED → ASSIGNED
Assignee | ||
Updated•21 years ago
|
Whiteboard: checkin0.9
Assignee | ||
Comment 17•21 years ago
|
||
Missed 0.9.
Flags: blocking0.9? → blocking1.0?
Whiteboard: checkin0.9
Target Milestone: Firefox0.9 → Firefox1.0beta
Comment 18•21 years ago
|
||
Not blocking 1.0, but feel free to check this in.
Flags: blocking1.0? → blocking1.0-
Comment 19•21 years ago
|
||
fixed branch and trunk
Status: ASSIGNED → RESOLVED
Closed: 21 years ago → 21 years ago
Resolution: --- → FIXED
Whiteboard: fixed-aviary1.0
Assignee | ||
Comment 20•21 years ago
|
||
Note: mozilla/toolkit/themes/pinstripe/global/formatting.css and mozilla/toolkit/themes/qute/global/formatting.css already contain these css rules on branch and trunk.
Updated•16 years ago
|
Product: Firefox → Toolkit
Updated•8 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•