Closed Bug 207403 Opened 22 years ago Closed 21 years ago

URLs in the js console are not formatted like a link (blue, underlined) anymore

Categories

(Toolkit Graveyard :: Error Console, defect, P3)

x86
Windows XP
defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.7.4

People

(Reporter: steffen.wilberg, Assigned: steffen.wilberg)

References

()

Details

(Keywords: regression, Whiteboard: fixed-aviary1.0)

Attachments

(1 file, 2 obsolete files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030526 Mozilla Firebird/0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030526 Mozilla Firebird/0.6

URLs in the js console are not formatted like a link.

Reproducible: Always

Steps to Reproduce:
1. Open Javascript console.
2. Look for a link in it. If you can't find one, browse to
http://java.sun.com/getjava/

Actual Results:  
The url in the js console is not formatted like a link, e.g. blue and underlined.


Expected Results:  
The url should be formatted like a link so that you know where to click on (not
on Source File, not on Line #).

Mozilla does this right.
Confirmed using Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.4b)
Gecko/20030529 Mozilla Firebird/0.6

=> change status to "New" since I didn't find a related, already existing bug

Note: I don't get a JS error when visiting java.cun.com - perhaps one has to use
a different page...
Status: UNCONFIRMED → NEW
Ever confirmed: true
Problem still exists in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b)
Gecko/20030726 Mozilla Firebird/0.6.1

Use http://www.javascriptkit.com/javatutors/errortest.htm for testing, which
should remain permanently erroneous.
QA Contact: asa
I am experencing this bug with FireFox 0.8 

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040206 Firefox/0.8

Priority: -- → P3
Target Milestone: --- → Firefox1.0beta
chrome://global/content/console.xul needs to reference
chrome://commmunicator/skin/formatting.css - then all will be well : )
Thanks for the tip. But we're not using
chrome://commmunicator/skin/formatting.css anywhere in Firefox, so I'd suggest
to add the rules we need to console/skin/console.css.
OS: Windows XP → All
Hardware: PC → All
Attached patch patch: add rules to console/skin/console.css (obsolete) (deleted) β€” β€” Splinter Review
I've left out some rules that don't work:
.text-link:focus { color:red }
.text-link:hover:active { color: red }
.text-link[visited="true"] { color: purple }
Assignee: firefox → steffen.wilberg
Status: NEW → ASSIGNED
Attachment #144317 - Flags: review?(bugs)
marking fixed.
I just saw that there was a patch in here. Some time wasted.
I put the rules in the toolkit formatting.css file. class text-link can be useful. 
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Comment on attachment 144317 [details] [diff] [review]
patch: add rules to console/skin/console.css

Fixed by pch.
Attachment #144317 - Attachment is obsolete: true
Attachment #144317 - Flags: review?(bugs)
Target Milestone: Firefox1.0beta → Firefox0.9
Attached image Screenshot of regression (obsolete) (deleted) β€”
Did this patch cause the link in the page info blue and the context menu to it
underlined?
(In reply to comment #9)
> Did this patch cause the link in the page info blue and the context menu to it
> underlined?
Yes and no. It wasn't my patch, but pch's checkin for this bug:
http://bonsai.mozilla.org/cvsquery.cgi?date=explicit&mindate=03%2F20%2F2004+00%3A01&maxdate=03%2F20%2F2004+00%3A01
See bug 238186.
Broken again with the new Winstripe theme. -> Reopening, at least for Windows.
Status: RESOLVED → REOPENED
OS: All → Windows XP
Hardware: All → PC
Resolution: FIXED → ---
Target Milestone: Firefox0.9 → ---
Attachment #144462 - Attachment is obsolete: true
Keywords: regression
Blocks: 244691
Summary: URLs in the js console should be formatted like a link (blue, underlined) → URLs in the js console are not formatted like a link (blue, underlined) anymore
Target Milestone: --- → Firefox0.9
Attached patch fix it again (deleted) β€” β€” Splinter Review
pch said in comment 7:
"I put the rules in the toolkit formatting.css file. class text-link can be
useful."
This patch puts them back there. It has no effect to page info (bug 238186).

Another option is to put these in toolkit/themes/winstripe/global/console.css,
but I agree with pch that these rules can be useful.
Comment on attachment 150378 [details] [diff] [review]
fix it again

Mike, this is a regression fix for 0.9.
Attachment #150378 - Flags: review?(mconnor)
patch ready.
Flags: blocking0.9?
Comment on attachment 150378 [details] [diff] [review]
fix it again

blech, this old chestnut? :)
Attachment #150378 - Flags: review?(mconnor) → review+
-> js console.
Component: General → JavaScript Console
QA Contact: firefox.js-console
Status: REOPENED → ASSIGNED
Whiteboard: checkin0.9
Missed 0.9.
Flags: blocking0.9? → blocking1.0?
Whiteboard: checkin0.9
Target Milestone: Firefox0.9 → Firefox1.0beta
Not blocking 1.0, but feel free to check this in.
Flags: blocking1.0? → blocking1.0-
fixed branch and trunk
Status: ASSIGNED → RESOLVED
Closed: 21 years ago21 years ago
Resolution: --- → FIXED
Whiteboard: fixed-aviary1.0
Note:
mozilla/toolkit/themes/pinstripe/global/formatting.css and
mozilla/toolkit/themes/qute/global/formatting.css already contain these css
rules on branch and trunk.
Product: Firefox → Toolkit
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: