Reproducible: Always Steps to Reproduce: 1. Select View | Show/Hide | Site Navigation Bar | Show Only As Needed 2. Open http://www.mozilla.org/ in one tab 3. Open http://slashdot.org/ in another tab 4. Go back to the tab that has http://www.mozilla.org/ already open Expected Results: The Site Navigation Bar is hidden because it is not needed. Actual Results: The Site Navigation Bar is still shown. I closed a similar bug as WFM because it didn't mention the tabs and therefore I could not reproduce the problem. After seeing this bug occur many times I finally realized that it's necessary to have at least two tabs open. Also, you only see the bug immediately after you switch tabs -- if you perform any navigation after switching tabs, the Site Navigation Bar is hidden if not needed. I can reproduce this bug with trunk build 2003052708 on Windows 98 with a new profile.

Comment on attachment 125622 [details] [diff] [review] A simple patch that seems to work. Won't this cause weird flicker if you go from one tab that needs a link toolbar to another tab that needs a link toolbar?

No, for some reason it doesn't. The only time I see a flicker is if I have the "Show Only As Needed" option on, I am on a page that has a link toolbar, and I open a link in a new tab with a page that has a link toolbar. And in that case the disturbance of the link toolbar disappearing and reappearing is less jarring than a new tab appearing and loading. Simply switching between tabs that have a link toolbar is exactly as without this patch.

Comment on attachment 125622 [details] [diff] [review] A simple patch that seems to work. I thought that the idea was to keep the link toolbar visible even when switching to a tab without links. At least, that's how I like it :-P

I thought that's what "Show Always" was for. "Show Only As Needed" should truly show the site nav bar only when needed.

Comment on attachment 125622 [details] [diff] [review] A simple patch that seems to work. r=jag I'm kinda wondering about the flicker myself... Say you have tabs A and B, both having need of a link toolbar. When you switch from A to B, you'll end up hiding and showing the toolbar, which may cause flicker.

jag: the way I (mis?)read it is that changing the tab doesn't hide the toolbar, instead it just resets a flag giving the toolbar a chance to autohide.

timeless checked this in.

*** Bug 214799 has been marked as a duplicate of this bug. ***