Closed
Bug 207641
Opened 21 years ago
Closed 21 years ago
update localeVersion for 1.4 final
Categories
(Core :: Internationalization: Localization, defect)
Core
Internationalization: Localization
Tracking
()
VERIFIED
FIXED
mozilla1.4final
People
(Reporter: kairo, Assigned: rchen)
References
Details
(Whiteboard: [ns tree fixed as well][adt1][only fixed on branch])
Attachments
(2 files)
(deleted),
patch
|
rchen
:
review+
blizzard
:
superreview+
blizzard
:
approval1.4+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review |
As bug 154927 is still unfixed, we need another manual update for the
localeVersion in 1.4 final.
Reporter | ||
Comment 2•21 years ago
|
||
OK, here's the patch for the 1.4 branch. Hope to get this in soon enough...
Reporter | ||
Updated•21 years ago
|
Attachment #124562 -
Flags: superreview?(blizzard)
Attachment #124562 -
Flags: review?(rchen)
Comment 3•21 years ago
|
||
Comment on attachment 124562 [details] [diff] [review]
flip localeVersion to 1.4 on the branch
rs=blizzard
Attachment #124562 -
Flags: superreview?(blizzard) → superreview+
Reporter | ||
Updated•21 years ago
|
Summary: update loacleVersion for 1.4 final → update localeVersion for 1.4 final
Comment 4•21 years ago
|
||
rc1 ships with "1.4b"
(Shouldn't this be a 1.4 blocker?)
Reporter | ||
Comment 5•21 years ago
|
||
irve:
As you see, I requested blocking1.4 -ä but noone did set it to plus or minux yet...
rchen:
Could you r= this one as well?
Thanks!
Updated•21 years ago
|
Flags: blocking1.4? → blocking1.4+
Comment 6•21 years ago
|
||
Comment on attachment 124562 [details] [diff] [review]
flip localeVersion to 1.4 on the branch
The proper way to get approval for 1.4 is to put an approval1.4? for the patch
and we'll see it.
Attachment #124562 -
Flags: approval1.4+
Comment 7•21 years ago
|
||
I went ahead and checked this in because we needed it for RC2.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Comment 8•21 years ago
|
||
I'll go ping bliz, and see if anyone has helped with the ns side.
if not, I can do it.
Comment 9•21 years ago
|
||
ns side fixed, a=leaf
Comment 10•21 years ago
|
||
adding all the status whiteboard, target milestone, keyword foo.
Comment 11•21 years ago
|
||
Could some one verify this and change the keyword to "verified 1.4"? cause it's
hard for me (QA) to verify at this point. thanks!
Assignee | ||
Comment 12•21 years ago
|
||
Comment on attachment 124562 [details] [diff] [review]
flip localeVersion to 1.4 on the branch
Sorry, Kairo. I should have reviewed earlier.
Attachment #124562 -
Flags: review?(rchen) → review+
Assignee | ||
Comment 13•21 years ago
|
||
Yuying, you can verify by installing the new build. Unzip en-US.jar. Check the
files content.rdf. See if localeVersion changed to "1.4", like
<RDF:Description about="urn:mozilla:locale:en-US:editor"
chrome:localeVersion="1.4"/>
Comment 14•21 years ago
|
||
None of the contents-region.rdf or contents-platform.rdf files were updated.
Should they be?
Comment 15•21 years ago
|
||
This is the content.rdf file in 06-10 1.4 branch build on WinXP, not sure if it
matches in comment #13, also I saw 1.4b not 1.4:
----------------------------------------------------
<?xml version="1.0"?>
<RDF:RDF xmlns:RDF="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
xmlns:chrome="http://www.mozilla.org/rdf/chrome#">
<!-- list all the locales being supplied -->
<RDF:Seq about="urn:mozilla:locale:root">
<RDF:li resource="urn:mozilla:locale:en-US"/>
</RDF:Seq>
<!-- locale information -->
<RDF:Description about="urn:mozilla:locale:en-US">
<chrome:packages>
<RDF:Seq about="urn:mozilla:locale:en-US:packages">
<RDF:li resource="urn:mozilla:locale:en-US:necko"/>
</RDF:Seq>
</chrome:packages>
</RDF:Description>
<!-- Version Information. State that we work only with major version of this
package. -->
<RDF:Description about="urn:mozilla:locale:en-US:necko"
chrome:localeVersion="1.4b"/>
</RDF:RDF>
Assignee | ||
Comment 16•21 years ago
|
||
Yuying, the files in the build are not updated. If they were checked in, you
should see them in the next build.
David, I think you are right. We need to update them.
Comment 17•21 years ago
|
||
I'll sweep and update the other 1.4b occurances. (I sent private email about
this as well)
Comment 18•21 years ago
|
||
I've swept and fix the occurances that weren't fixed.
not sure what happened here.
thanks to dbaron for pointing this out.
Reporter | ||
Comment 19•21 years ago
|
||
oops, I guess this was my fault, I think I only included contents.rdf in my
patch, and not contents*.rdf - I wish we could really automate this one, it's
annoying...
Sorry!
Comment 20•21 years ago
|
||
Verified the the version has been changed to 1.4 in contents.rdf with 06-11 1.4
branch build on WinXP. But don't see the contents-region.rdf or
contents-platform.rdf file under same directory though, do I have to verify them
in some where else also?
Assignee | ||
Comment 21•21 years ago
|
||
contents-region.rdf is in us.jar in region.xpi, win/contents-platform.rdf is in
en-win.jar, mac/contents-platform.rdf is in en-mac.jar... All of them are
renamed to contents.rdf in each component in the product.
Comment 22•21 years ago
|
||
That case, the are all in 1.4 in contents.rdf on different platforms. Mark as
verified.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•