I'm not certain that this is wrong, so feel free to correct me if i'm wrong.

It works, but they probably shouldn't be doing it.

This is not an rdf bug, please file bugs for the affected components.

Comment on attachment 146740 [details] [diff] [review] createInstance >-const RDFContainer = Components.classes["@mozilla.org/rdf/container;1"].getService(Components.interfaces.nsIRDFContainer); >+const RDFContainer = Components.classes["@mozilla.org/rdf/container;1"].createInstance(Components.interfaces.nsIRDFContainer); Possible abuse of RDFContainer here - it gets Init()ed multiple times. Even if that's allowable IMHO this should say var rather than const. >- RDFC = Components.classes["@mozilla.org/rdf/container;1"].getService(); >+ RDFC = Components.classes["@mozilla.org/rdf/container;1"].createInstance(); > if (RDFC) RDFC = RDFC.QueryInterface(Components.interfaces.nsIRDFContainer); r=me (subject to possible r- above) if you fix the bad createInstance fu.

Comment on attachment 146740 [details] [diff] [review] createInstance I'm guessing Neil meant to say something like "combine those two statements into one" for the search-editor.js part of the patch. If not, I say go ahead and do it. sr=jag with that. Though unspecified, I believe init can be called multiple times to "reinitialize" the container to the new context. RDFContainerImpl::Init seems to have been written with this in mind.

I wrote exactly what I meant to write, but it meant what jag wrote ;-)

timeless, Are you still working on this ?

Okay, I should have put this one in either the toolkit or the suite patch (though I couldn't, really, crossing repos), but suitekit's pretty cute, for an afterthought.

Comment on attachment 355361 [details] [diff] [review] suite/Instance [checked in] http://hg.mozilla.org/comm-central/rev/610f02e3c92c

Comment on attachment 355359 [details] [diff] [review] mail/Instance [checked in] http://hg.mozilla.org/comm-central/rev/f4eb87ffd715

http://hg.mozilla.org/mozilla-central/rev/8dcbd3d42d68 http://hg.mozilla.org/mozilla-central/rev/562fa5121cec Close enough: please to be filing new bugs for any instances I might have missed.