Closed
Bug 21061
Opened 25 years ago
Closed 25 years ago
Customize panel button does not work
Categories
(SeaMonkey :: Sidebar, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
M16
People
(Reporter: fornixon, Assigned: slamm)
References
Details
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
Overview Description:
The Customize Panel button in the Customize Sidebar dialog box doesn't allow for
customization of content
Steps to Reproduce:
1)start mozilla
2)click the customize button on the sidebar
3)add the weather panel
4)select weather from the right-hand list
5)click the Customize Panel... buttton
Actual Results:
The Customize Panel.. and Remove buttons get bigger, and the left-side list
and the dialog window get taller, and that's it.
Expected Results:
Button should lead to some sort of Netcenter page to allow content to be
customized. ie choose cities for weather, ticker symbols for stocks, etc.
Build Date & Platform Bug Found:
Build ID 1999120608, Win98
Additional Builds and Platforms Tested On:
none
Additional Information:
none
Assignee | ||
Updated•25 years ago
|
Status: NEW → ASSIGNED
Summary: customize panel button in customize sidebar dialog doesn't work → Customize panel button does not work
Target Milestone: M16
Comment 1•25 years ago
|
||
Comment 2•25 years ago
|
||
The Customize Panel button now works. But the window that pops up is empty
for the few panels I tried. Also, these panels have no title attributes
available (turn on the debug function in customize.js and see the title/url
messages).
Hope this helps,
Cyril
Comment 3•25 years ago
|
||
Comment 4•25 years ago
|
||
What this 2nd patch does:
- When the Customize Panel button is clicked, Customize Panel and Remove buttons
don't grow bigger, and left-side list does not grow taller.
- The window can be resized correctly. The 2 lists will then grow larger,
showing more items. Buttons will keep their sizes.
This is done by adding a flex to the main horizontal box, and by removing
the flex of the box around Customize Panel and Remove buttons.
Cyril
Comment 6•25 years ago
|
||
fornixon@globalserve.net is now the-enigman@home.com. CC'ing the new address to
ensure I am notified of all changes to this bug.
Comment 7•25 years ago
|
||
slamm, this is marked m16, it should be in for beta, right? there are two
problems here, the button problem, and the customize button problem
Assignee | ||
Updated•25 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•25 years ago
|
||
Thank you for the patch. I changed it a little. Instead of bringing up the
customize dialogs, it loads the customize dialog in a chromeless window. It will
be up to the panel provider to provide a customize UI.
Comment 9•25 years ago
|
||
In function CustomizePanel() in customize.js line 231, 'selected-panels'
should be replaced by 'current-panels'. That's the name of the right tree
control containing user's selections.
Cyril
Updated•25 years ago
|
Status: RESOLVED → REOPENED
Updated•25 years ago
|
Resolution: FIXED → ---
Comment 10•25 years ago
|
||
This is not working, re-opening. I'm getting a JS error in customize.js, line
232. I think this is what borto is referring to.
To reproduce:
1. Open Sidebar, launch customize dialogue
2. Select My News under Panels currently in Sidebar
3. Select Customize Panel (which becomes active after selecting My News)
Results: Nothing but JS error in console
Expected: Chromeless window
Using Linux 1/11 build
Updated•25 years ago
|
Status: REOPENED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
Updated•25 years ago
|
Status: RESOLVED → VERIFIED
Comment 11•25 years ago
|
||
okay, this is fixed now
Comment 12•25 years ago
|
||
verified with 1/19 builds
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•