lxr shows no caller of this function, only declarations/impls now, this function is the only user of nsProgressDlg.{js,xul}: http://lxr.mozilla.org/seamonkey/search?string=nsprogressdlg so that can be removed as well

Comment on attachment 126823 [details] [diff] [review] patch r=me assuming you tested carefully and can still get a progress dialog when downloading files or opening them in helpers... ;)

Comment on attachment 126823 [details] [diff] [review] patch bz: Yes, I did verify that I still get progress windows :)

Comment on attachment 126823 [details] [diff] [review] patch sr=darin are you sure someone didn't intend to use this for something? IOW, is this really dead code? perhaps it would be wise to drop a line to whomever added this code to the tree.

well this dialog was used once: 1.61 law%netscape.com May 3 2001 Bug 52454; fix lots of external app service bugs and enable new helper app dlg; r=pchen@netscape.com, sr=mscott@netscape.com (law was also the one who initially checked in nsProgressDlg) This checkin changed it so that ->ShowProgressDialog (and therefore nsProgressDlg) was no longer used: 1.131 law%netscape.com Feb 20 2002 Bug 27609; change exthandler to use new progress dialog and properly report i/o errors; r=bzbarsky, sr=mscott In this context, see bug 27609 comment 47: [...] (the ones named nsProgressDlg.* are obsolescent) [...] So, the author of this code knew all about this.

checked in.

Um, this seems to have killed the camino build. src/embedding/CHBrowserService.mm:294: no `nsresult CHBrowserService::ShowProgressDialog(nsIHelperAppLauncher*, nsISupports*)' member function declared in class `CHBrowserService'

Checked in same removal change to camino/src/embedding/CHBrowserService.mm (which SeaMonkey lxr does not show). I left chimera/src/embedding/CHBrowserService.mm be, since it should be obsolete (and is a closed CVS partition anyway).

oh, right... I'm really sorry about that, I only checked seamonkey lxr. bz, thanks for fixing!