Closed
Bug 211285
Opened 22 years ago
Closed 22 years ago
void nsRuleNetwork::Init doesn't check the return value of PL_DHashTableInit
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
References
()
Details
Attachments
(1 file)
|
(deleted),
patch
|
dbaron
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
This is a code inspection bug.
QA:
To verify that this bug is fixed, make sure that all callers in of
PL_DHashTableInit in the indicated class/file check and handle a failure return
result.
To verify that this bug is invalid, simply verify (e.g. with lxr) that
PL_DHashTableInit is no longer used by the indicated class/file.
PL_DHashTableInit returns a PRBool indicating whether it succeeded.
PL_DHashTableInit *can* fail. Code can not assume that table->ops or table-
>data will be null (in fact it probably will not be), although in all
likelyhood table->entryStore will be null it probably isn't safe to assume this.
Code at time of bug filing:
108 void
109 nsRuleNetwork::Init()
110 {
111 mNextVariable = 0;
112 PL_DHashTableInit(&mSymtab, &gOps, nsnull, sizeof(SymtabEntry),
PL_DHASH_MIN_SIZE);
113 }
Attachment #128527 -
Flags: superreview?(bzbarsky)
Attachment #128527 -
Flags: review?(dbaron)
|
||
Updated•22 years ago
|
Attachment #128527 -
Flags: superreview?(bzbarsky) → superreview+
|
||
Updated•22 years ago
|
Attachment #128527 -
Flags: review?(dbaron) → review+
checked in
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: shrir → xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•