This is a code inspection bug. QA: To verify that this bug is fixed, make sure that all callers in of PL_DHashTableInit in the indicated class/file check and handle a failure return result. To verify that this bug is invalid, simply verify (e.g. with lxr) that PL_DHashTableInit is no longer used by the indicated class/file. PL_DHashTableInit returns a PRBool indicating whether it succeeded. PL_DHashTableInit *can* fail. Code can not assume that table->ops or table- >data will be null (in fact it probably will not be), although in all likelyhood table->entryStore will be null it probably isn't safe to assume this. Code at time of bug filing: 60 void 61 nsContentSupportMap::Init() 62 { 63 PL_DHashTableInit(&mMap, &gOps, nsnull, sizeof(Entry), PL_DHASH_MIN_SIZE); 64 }

Comment on attachment 128528 [details] [diff] [review] patch > PRBool Get(nsIContent* aElement, nsTemplateMatch** aMatch) { >+ if (!mMap.ops) >+ return NS_ERROR_NOT_INITIALIZED; >+ Actually, you better return a value of the right type here. I think you want PR_FALSE.

.

checked in