Closed Bug 211293 Opened 22 years ago Closed 10 years ago

nsSecureBrowserUIImpl::ResetStateTracking doesn't check the return value of PL_DHashTableInit

Categories

(Core Graveyard :: Security: UI, defect)

x86
Windows 2000
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 962608

People

(Reporter: timeless, Unassigned)

References

()

Details

(Whiteboard: [kerh-cuz])

This is a code inspection bug. QA: To verify that this bug is fixed, make sure that all callers in of PL_DHashTableInit in the indicated class/file check and handle a failure return result. To verify that this bug is invalid, simply verify (e.g. with lxr) that PL_DHashTableInit is no longer used by the indicated class/file. PL_DHashTableInit returns a PRBool indicating whether it succeeded. PL_DHashTableInit *can* fail. Code can not assume that table->ops or table- >data will be null (in fact it probably will not be), although in all likelyhood table->entryStore will be null it probably isn't safe to assume this. Code at time of bug filing: 376 if (mTransferringRequests.ops) { 377 PL_DHashTableFinish(&mTransferringRequests); 378 mTransferringRequests.ops = nsnull; 379 } 380 PL_DHashTableInit(&mTransferringRequests, &gMapOps, nsnull, 381 sizeof(RequestHashEntry), 16); 382 }
Mass reassign ssaux bugs to nobody
Assignee: ssaux → nobody
Product: PSM → Core
Whiteboard: [kerh-cuz]
QA Contact: bmartin → ui
Version: Other Branch → Trunk
Init is infallible now.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.