Open Bug 211849 Opened 21 years ago Updated 2 years ago

Core and Toolkit should not contain application-specific dependencies

Categories

(Firefox Build System :: General, defect)

defect

Tracking

(Not tracked)

People

(Reporter: benjamin, Unassigned)

References

(Depends on 1 open bug)

Details

In this checkin, an application-specific #ifdef was added to mozilla/toolkit. The toolkit should really be application-agnostic. I am working towards the XRE (super-set of the GRE) which would contain the toolkit (and upon which FB/TB would be built). When can this "temporary" hack be fixed? 06/08/2003 21:26 scott%scott-macgregor.org mozilla/ toolkit/ content/ xul.css 1.24 36/0 We need to make changes to toolkit's autocomplete for it to work in mail compose (for thunderbird). For now, add an ifdef which rebinds the autocomplete bindings to the old versions in mozilla\xpfe.
Blocks: 213228
I guess mscott used this ifdef to quickly run the new toolkit but I agree that it should be fixed now. Thought, strictly speaking, this bug does not depends or blocks bug 213228. The scope of the latter bug is only about not building xpfe/global before mozilla/toolkit. Another important thing to do in order to have an application independent toolkit would be to provide a mechanism to access the specific application name from the new toolkit (currently brand.dtd and brand.properties in global/en-US/locale are overwritten when building the stand-alone applications.)
No longer blocks: 213228
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: shrir → xptoolkit.widgets
Assignee: mscott → nobody
Depends on: 360648
Component: XUL → Build Config
Depends on: 710562
QA Contact: xptoolkit.widgets → build-config
Summary: toolkit should not contain application-specific dependencies → Core and Toolkit should not contain application-specific dependencies
Depends on: 716404
Product: Core → Firefox Build System
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.