Open
Bug 212851
Opened 21 years ago
Updated 9 years ago
don't install a smaller send/receive buffer than the default
Categories
(Core Graveyard :: Installer: XPInstall Engine, defect)
Core Graveyard
Installer: XPInstall Engine
Tracking
(Not tracked)
NEW
People
(Reporter: jo.hermans, Assigned: ssu0262)
References
()
Details
Attachments
(1 file)
(deleted),
text/plain
|
Details |
I noticed that nsSocket::Open() in XPinstall (see URL) calls setsockopt() to set
the size of the send and receive buffers of the socket to 32768 bytes.
Wouldn't it be better to check first the current size of the buffers (with
getsockopt), to make sure that we don't allocate smaller buffers than the
default ? For example, Tru64Unix uses 9K send and 40K send buffers by default,
and many platforms allow the administrator to fine-tune the default buffers. But
Mozilla would install its own buffer-size, even when it was a higher value.
I noticed this when I started to play with sysctl on my Mac, to boost my buffers
to 64K (default was 32K). This gave at least a 10% speed boost on my broadband
connection, especially in large downloads. Note that the Mac doesn't use an
installer (currently), so this piece of code is actually of no importance for
Macs. But other platforms might use this idea.
Reporter | ||
Comment 1•21 years ago
|
||
oops
Summary: http://lxr.mozilla.org/seamonkey/source/xpinstall/wizard/libxpnet/src/nsSocket.cpp#178 → don't install a smaller send/receive buffer than the default
Reporter | ||
Comment 2•20 years ago
|
||
Something like this ?
Updated•15 years ago
|
QA Contact: agracebush → xpi-engine
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•