Closed Bug 215041 Opened 21 years ago Closed 21 years ago

Add support for WinIE's _main target for sidebars (in addition to _content)

Categories

(Core :: DOM: Navigation, defect)

Product:
Core
Component:
DOM: Navigation
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: hyatt, Assigned: hyatt)

References

Details

Attachments

(2 files)

Add support for _main
(deleted), patch
ian
: review+
bugs
: superreview+
Details | Diff | Splinter Review
Patch a couple of other places.
(deleted), patch
brendan
: review+
bugs
: superreview+
Details | Diff | Splinter Review
WinIE supports the _main target. Currently our target is called _content. This patch adds support for _main, so that we have WinIE compatibility with all of their Explorer Bars in both SeaMonkey and Firebird.
Attached patch Add support for _main (deleted) — — Splinter Review
Comment on attachment 129165 [details] [diff] [review] Add support for _main It's ridiculous that we have to check this in five separate places in three separate files, but whatever. r=hixie.
Attachment #129165 - Flags: review+
Initial patch landed. Still doesn't work though. I must have missed a spot. I'll keep looking.
Status: NEW → ASSIGNED
Attached patch Patch a couple of other places. (deleted) — — Splinter Review
This patch gets the one I missed. The Google IE sidebar works in Firebird or Seamonkey now with this patch.
Yeah, Hixie's right -- why are these special cases smeared all over the tree? /be
Comment on attachment 129168 [details] [diff] [review] Patch a couple of other places. All I ask is that danm have a chance to comment, even if you go fast and stuff. I'll file a followup bug to consolidate the special case code. /be
Attachment #129168 - Flags: review+
Yay, more reserved property names. Don't you have to worry about making _main replaceable like the other similar window properties?
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
This is just for targeting. There is no window._main like there is a window._content, so I don't think that's an issue.
Actually, I could be wrong about this. Let me write some WinIE tests. If they support window._main, then you're right.
Yes, window._main is not defined in WinIE. It's just a target, not a property. We match their behavior.
FYI, this caused bug 217886
Blocks: 217886
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: