Closed Bug 218134 Opened 21 years ago Closed 17 years ago

BeOS gfx library needs work

Categories

(Core Graveyard :: GFX: BeOS, defect)

x86
BeOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: beos, Assigned: beos)

References

Details

Attachments

(1 file, 1 obsolete file)

Currently, the BeOS gfx library has a couple bugs, some of which are already reported here in BugZilla. I will mark the bugs that I think this will block/fix. Sergei, if I am wrong on some of those that this blocks, please update the depends/blocks fields, when you get a chance. Patch to follow ...
Blocks: 133013
Attached patch first attempt (obsolete) (deleted) — Splinter Review
Ok, this patch incorporates the changes given to me by Sergei, that he has made to the gfx code. I have gone through his changes, plus, did some overall cleanup of all the beos code for the gfx library. I also tried to remove all warnings from the build of the gfx library, but I can't seem to figure out why the warning below is still being generated, as to me, it makes not sense. /Dev/Projects/mozilla/bezilla/mozilla/dist/include/gfx/nsDeviceContext.h:97: warning: `DeviceContextImpl::CreateRenderingContext(void *, nsIRenderingContext *&)' was hidden In file included from /Dev/Projects/mozilla/bezilla/mozilla/gfx/src/beos/nsFontMetricsBeOS.h:43, from /Dev/Projects/mozilla/bezilla/mozilla/gfx/src/beos/nsRenderingContextBeOS.cpp:41: /Dev/Projects/mozilla/bezilla/mozilla/gfx/src/beos/nsDeviceContextBeOS.h:68: warning: by `nsDeviceContextBeOS::CreateRenderingContext(nsIWidget *, nsIRenderingContext *&)' My guess is that something in one of the macros is causing it, as I don't see the method declaration that is supposedly being hidden. Anybody have any ideas?
typedef void * nsDrawingSurface; 97 NS_IMETHOD CreateRenderingContext(nsDrawingSurface aSurface, nsIRenderingContext *&aContext); Afaik you didn't implement this flavor.
Attached patch ok, no more warnings (deleted) — Splinter Review
/me smacks self on head Thanks timeless. I don't know where my brain was :-)
Attachment #130792 - Attachment is obsolete: true
Just finished 1.5b "release" build. So after testing nsWidget patch i'll probably resubmit this patch, adding lot of comments there - about where is hack, where i have doubts, and with TODO-s notices. I hope Paul you will get some time with it for more intensive testing of this gfx version, to see if any additional memory leak or crashbug wasn't introduced.
maybe we need separate patches for style and for content. From developers POV it will be very hard to figure later, what was really changed.
is Bug 201536 still a issue?
This bug and patch is now for reference only. Lot of proposed changes are incorporated through other bugs via separate commits. But some ideas may be still usable in future. So, patch itself is obsolete for sure.
tqh and sergei, should we close this bug marked "WONTFIX"?
Yeah, I think so.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → WONTFIX
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: