Closed Bug 21879 Opened 25 years ago Closed 25 years ago

optimize SetAttribute() to handle same value

Categories

(Core :: DOM: Core & HTML, defect, P3)

defect

Tracking

()

VERIFIED FIXED

People

(Reporter: waterson, Assigned: shaver)

References

()

Details

(Keywords: perf)

Attachments

(1 file)

Avoid reflow if SetAttribute() sets attribute to identical value.
Attached patch fix vidur & shaver hacked up (deleted) — Splinter Review
Blocks: 20110
Status: NEW → ASSIGNED
Ah, dammit.  I wanted to get this in for M13.  Vidur, do you think it's too
risky for the performance gain?

Waterson: you said you depended on this behaviour?  Is that still true?
Some of the RDF template code depends on this behavior. Since there is currently
no mechanism for "knowing" when a datasource is added/removed from the composite
datasource, this was a dirty hack to force template-generated content to be
rebuilt.

I can't remember off the top of my head what will break if you make this change.
My guess is that, if you did it for HTML elements only, -nothing- would break
(most templates are generated using XUL elements).

I'll file a bug vs. myself to add a "datasource add/remove" listener interface
on the composite datasource, and make the template generator respond
appropriately.
Depends on: 24110
Keywords: perf
Summary: [perf] optimize SetAttribute() to handle same value → optimize SetAttribute() to handle same value
shaver: ignore bug 24110. just whack away and we'll fix what gets broke.
I've got the first part of this fix (the part that actually looks like the old
== new optimization) in my tree, so it'll probably land soon.

(About freaking time, sorry.)
Fixed, baby.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Mass update of qa contact
QA Contact: gerardok → janc
Component: DOM Level 1 → DOM Core
QA contact Update
QA Contact: janc → desale
Updating QA contact to Shivakiran Tummala.
QA Contact: desale → stummala
verified, fix checked in
Status: RESOLVED → VERIFIED
No longer blocks: 21762
Blocks: 21762
Component: DOM: Core → DOM: Core & HTML
QA Contact: stummala → general
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: