Freetype printing puts Xft build into an infinite loop (of a sort) because it's assumed that font names are always in FFRE form, which isn't true of Xft build. I'm gonna upload a patch in a moment.

Comment on attachment 131350 [details] [diff] [review] a simple patch asking for r & sr.

Comment on attachment 131350 [details] [diff] [review] a simple patch Louie, can you review? This is a simple change to avoid an infinite loop in Xft build and PS print module with FT2.

Comment on attachment 131350 [details] [diff] [review] a simple patch I verify the patch. It works fine.

*** Bug 220452 has been marked as a duplicate of this bug. ***

Thanks all. The patch jut got landed.

Um.. so if "value" is "sans-serif", we will end up appending "serif"?

I realized that, but didn't bother to fix because family names like 'serif' and 'sans-serif' wouldn't be matched by the font search code of FT2 printing module anyway. If one wants a rather faithful WYSWYG with FT2 printing module in Xft build, one has to specify 'concrete' family names in Edit|Pref|Appearance|Font instead of generic names like 'sans', 'sans-serif' This issue has to be dealt with in bug 190031. See also bug 211763.

Comment on attachment 131350 [details] [diff] [review] a simple patch This is a simple fix to enable freetype printing in Xft build. Currently, enabling freetype printing (at configuration time and run-time) puts Mozilla into an infinite loop. With this patch, Mozilla can printing CJK pages (that the default PS printing module can print only with a single font) with multiple fonts (the same set of fonts as used for the screen rendering). Risk: very low. it doesn't affect the mozilla.org's default build (except for a couple of more if-clauses). Constituency: Currently not big partly because one of Xft build's biggest 'suppliers', RedHat disables freetype at the configuration time, but that may change with this fix. Even if not, other Linux distributions may have already shipped Xft builds with FT2 enabled or are likely to with this fixed.

Comment on attachment 131350 [details] [diff] [review] a simple patch too late for 1.5.

*** Bug 222153 has been marked as a duplicate of this bug. ***