See line http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/downloads/content/pref-downloads.js#61

-> me, 0.7

Comment on attachment 131772 [details] [diff] [review] localization patch I think this is a blocker for 0.7. 0.6 and 0.6.1 both shipped with localization bugs, I'd like 0.7 to not share that

as a note, this fixes both this bug and bug 219192 (not worth writing two patches for essentially the same bug).

Mike, there's some more in pref-downloads.js: targetFolder.append("My Downloads"); // XXXben localize http://lxr.mozilla.org/mozilla/source/browser/components/prefwindow/content/pref-downloads.js#205 dir.append("My Downloads"); // XXXben localize http://lxr.mozilla.org/mozilla/source/browser/components/prefwindow/content/pref-downloads.js#300 // XXXben LOCALIZE! var title = "Remove Actions"; var msg = "The selected Actions will no longer be performed when files of the affected types are downloaded. Are you sure you want to remove these Actions?"; http://lxr.mozilla.org/mozilla/source/browser/components/prefwindow/content/pref-downloads.js#341

I adapted your patch - it wasn't quite "localizable" in the strict sense - strings shouldn't be appended, substitution values should be used instead. I'm going to check this into the trunk and the .7 br shortly.

Ben, thanks, I knew this patch wasn't quite right, haven't had time to come back to it in the last few days. Your patch (and mine) doesn't address the strings mentioned in comment 5 though, which includes the confirmation dialog when removing a file type.

Fixed, branch and trunk, 0.7

Thanks for fixing "Select Download Folder". However, the strings mentioned in comment 5 are still not fixed. -> reopening; changing summary.

oops. those weren't addressed by the attached patch. This is not going to make the cut for tomorrow so -> .8

I made this patch along Ben's lines. It fixes "My Downloads", "Remove Actions", and the remove actions message.

Comment on attachment 132033 [details] [diff] [review] patch for the remaining problems >+ var bundle = document.getElementById("strings"); >+ var description = bundle.getString("myDownloads"); >... >+ targetFolder.append(description); >Index: mozilla/toolkit/mozapps/downloads/locale/unknownContentType.properties >=================================================================== >+myDownloads=My Downloads Is there a way to access the downloads.label entity in the pref-downloads.dtd from javascript? Because it's the same: <!ENTITY downloads.label "My Downloads">

no, its not possible. Patch looks good though.

r=me, and checked in.

Comment on attachment 132033 [details] [diff] [review] patch for the remaining problems Thanks Ben. (removing review request).

Egg on my face for review+'ing this one. Steffen, your last patch caused the Options dialog to break... if you visit Downloads, then change panels and then click OK, the dialog won't dismiss. I've checked in a fix for it already, but the reason is as follows: - you referenced the 'document' object in the OK callback function. If the user visits the page and then changes away from it, the OK callback is registered, but the document it was created into has disappeared. So you need to create the string bundle manually using the API. That's what I checked in.

> Steffen, your last patch caused the Options dialog to break... if you visit > Downloads, then change panels and then click OK, the dialog won't dismiss. ??? Wfm with yesterday's build. But thanks a lot for the nice explanation.

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change