Closed Bug 220232 Opened 21 years ago Closed 21 years ago

Bugzilla::Bugmail dies if a bug summary is NULL

Categories

(Bugzilla :: Email Notifications, defect)

2.17.4
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: justdave, Assigned: justdave)

Details

Attachments

(1 file)

Found this on Bugscape trying to send unsent bugmail from sanitycheck... It dies and leaves this in the log: Can't find param named summary at Bugzilla/Config.pm line 124. The bug it died on has a NULL summary (it was a recent import from another bug database [ myk's fault ;) ] ). The error is generated by PerformSubst(), which does a "defined" check on the substitution string, and looks for a param by that name if you didn't define a substitution string. The real cuplrit here, I think, is that we even allow NULL summaries in the database. The short_desc column is not defined with "NOT NULL" in our schema. Oops.
I've also experienced this problem with v2.17.6. Adding myself to the CC list to monitor any progress.
Why isn't the summary column NOT NULL?
Attached patch Patch v1 (deleted) — Splinter Review
We have a "mediumtext abuse" bug out there somewhere... it would make sense to tackle that at the same time if we're having to make a schema change to the short_desc field at all... this patch doesn't address that though.
Assignee: preed → justdave
Status: NEW → ASSIGNED
Attachment #141436 - Flags: review?(bbaetz)
Comment on attachment 141436 [details] [diff] [review] Patch v1 r=bbaetz If this breaks INSERT/UPDATEs, then we'll fix the callers.
Attachment #141436 - Flags: review?(bbaetz) → review+
Checking in checksetup.pl; /cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v <-- checksetup.pl new revision: 1.263; previous revision: 1.262 done
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Flags: approval+
Resolution: --- → FIXED
Target Milestone: --- → Bugzilla 2.18
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: