Closed
Bug 220626
Opened 21 years ago
Closed 20 years ago
Enable keyboard access to Blocked Popups notification bar
Categories
(Firefox :: Keyboard Navigation, defect, P2)
Firefox
Keyboard Navigation
Tracking
()
RESOLVED
FIXED
People
(Reporter: email, Assigned: doronr)
References
(Blocks 1 open bug, )
Details
(Keywords: access, helpwanted, Whiteboard: l10n impact)
Attachments
(2 files, 2 obsolete files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
mconnor
:
review+
mkaply
:
approval-aviary1.1a1+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5b) Gecko/20030901 Firebird/0.6.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5b) Gecko/20030901 Firebird/0.6.1+
There's no way to access the "Blocked Popups" window using the keyboard.
Reproducible: Always
Steps to Reproduce:
1. Navigate to a site that tries to open a popup: the "blocked popups" icon
appears in the status bar
2. Try to access the list of "blocked popups" using the keyboard
Actual Results:
You cannot access the "blocked popups" list using the keyboard
Expected Results:
Allowed some access using the keyboard -- perhaps through a tab or button
launching the blocked popups on the "Page Info" dialog box.
Perhaps a nice solution would be to integrate the "Blocked Popups" dialog into a
tab on the "Page Info" dialog.
If this was done, clicking on the "Blocked Popups" status icon would, instead,
take you to this tab on this dialog.
If another tab is not wanted, a "Blocked Popups" button could be added somewhere
on "Page Info" (IMO, this wouldn't be as nice as a tab).
Comment 1•21 years ago
|
||
We're getting REALLY short on keyboard shortcuts...
-> Confirming, taking to evaluate
Assignee: blake → mpconnor
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 2•21 years ago
|
||
we'll figure something out
Status: NEW → ASSIGNED
Priority: -- → P4
Summary: No keyboard access to "Blocked Popups" information → Enable keyboard access to "Blocked Popups" information
Target Milestone: --- → Firefox1.0beta
Seamonkey listed stuff like "Cookie Manager", "Popup Manager", etc. in the Tools
menu (IIRC, I haven't used SeaMonkey in a long time).
Instead of creating a hotkey just for the popup manager, could something like
this could be implemented in Firefox? Then the user could use the hotkey to
access the tools menu followed by a single key to run the popup manager (i.e.
ALT-T, P).
Comment 4•21 years ago
|
||
we have an idea for something a little more comprehensive, without the kludge
that Seamonkey has. But that's post-1.0 fodder.
Comment 5•21 years ago
|
||
More basic keyboard accessibility. If we can find a solution for 1.0, that'd be
great.
Flags: blocking-aviary1.0?
Updated•21 years ago
|
Component: General → Keyboard Navigation
QA Contact: jruderman
Comment 6•20 years ago
|
||
keyboard shortcuts affect l10n... PR or never
Flags: blocking-aviary1.0? → blocking-aviary1.0PR?
Whiteboard: l10n impact
Comment 7•20 years ago
|
||
anyone close to a patch?
mconnor, is there a link to the future plan?
Comment 8•20 years ago
|
||
chofmann, I don't know if anything is filed, but its linked to the per-site
settings for style etc. Blake would know, he told me about it a long time ago :)
Do we want a stopgap shortcut for this?
Comment 9•20 years ago
|
||
if we could get something that gets us asssibility to the blocked pop ups window
that was pretty low risk that would be great and would get strong consideration
to take next week.
Flags: blocking-aviary1.0PR? → blocking-aviary1.0PR+
Comment 10•20 years ago
|
||
No keyboard shortcuts, make the infobar focusable, put it into the tab sequence.
Comment 11•20 years ago
|
||
not going to block the release for this. We need to get the info bar focusable
for 1.0, though.
Flags: blocking-aviary1.0PR-
Flags: blocking-aviary1.0PR+
Flags: blocking-aviary1.0+
Comment 12•20 years ago
|
||
p4 priority - not a blocker. if a fully reviewed patch materializes, please
nominate for aviary approval.
Flags: blocking-aviary1.0+ → blocking-aviary1.0-
Comment 13•20 years ago
|
||
see also bug 262787 for the plugin finder bar.
Updated•20 years ago
|
Summary: Enable keyboard access to "Blocked Popups" information → Enable keyboard access to Blocked Popups / Plugin Finder notification bar
Comment 14•20 years ago
|
||
*** Bug 262787 has been marked as a duplicate of this bug. ***
Updated•20 years ago
|
Updated•20 years ago
|
Assignee: mconnor → aaronleventhal
Status: ASSIGNED → NEW
Updated•20 years ago
|
Assignee | ||
Comment 15•20 years ago
|
||
plugin finder bar is accessible already.
Summary: Enable keyboard access to Blocked Popups / Plugin Finder notification bar → Enable keyboard access to Blocked Popups notification bar
Assignee | ||
Comment 16•20 years ago
|
||
The easy way would be for the popup bar to have a button rather than require to
click on the messagebar itself. Or do we want to keep the clicking for IE
compat sake?
Assignee | ||
Comment 17•20 years ago
|
||
Assignee | ||
Comment 18•20 years ago
|
||
aaronl: want to try this out to see if its good enough?
Assignee: aaronleventhal → doronr
Assignee | ||
Comment 19•20 years ago
|
||
Comment 20•20 years ago
|
||
There should be either a xul:button or xul:menulist there for the options.
Otherwise the screen reader won't know what's up when the text is focused. A
real widget needs focused, plus that's less hacky, and more consistent with what
the plugin finder service does.
Something like " Firefox prevented this site from opening a popup window
<menulist>Popup options</menulist> "
Assignee | ||
Comment 21•20 years ago
|
||
This patch has a issue where if you use the keyboard (enter/space key) to show
the popup, the popup appears in the top left on the browser window.
Attachment #174495 -
Attachment is obsolete: true
Assignee | ||
Comment 22•20 years ago
|
||
clearing target milesone.
Status: NEW → ASSIGNED
Target Milestone: Firefox1.0beta → ---
Comment 23•20 years ago
|
||
We should test to make sure this doesn't mess up the XPI installation message
bar, example here: http://ted.mielczarek.org/code/mozilla/extensiondev/
Comment 24•20 years ago
|
||
Comment on attachment 176631 [details] [diff] [review]
Add a button and make it show the popup menu.
In the popup setter we should cache the value of
document.getAnonymousElementByAttribute(this, "anonid", "messageButton"
We use it 4 times right in a row.
Comment 25•20 years ago
|
||
The UI for popups seems broken in the nightly builds. It says "click here for
options". When I click there I get a menu with 1 item "edit popup blocker
options" and a separate line below that, with no more options.
If we're only going to have 1 thing you can do, we might as well forget the menu
and go straight to the edit popup blocker options dialog.
If we are going to have more than one option in that menu, then I think the
popup blocker warning bar should provide them in a combobox rather than a popup
menu activated by a button.
Comment 26•20 years ago
|
||
<button type="menu"> and <button type="menu-button"> should respond to space
bar, down arrow and Enter to be usable as a key navigable solution.
Assignee | ||
Updated•20 years ago
|
Attachment #176631 -
Flags: superreview?(bugs)
Comment 27•20 years ago
|
||
What's the status on this one? Does the current patch address activating the
button via the kbd? I don't see the last few comments addressed in the patch.
Updated•20 years ago
|
Flags: blocking-aviary1.1? → blocking-aviary1.1+
Assignee | ||
Comment 28•20 years ago
|
||
Comment on attachment 176631 [details] [diff] [review]
Add a button and make it show the popup menu.
This has bitrotted.
Attachment #176631 -
Attachment is obsolete: true
Attachment #176631 -
Flags: superreview?(bugs)
Assignee | ||
Comment 29•20 years ago
|
||
Attachment #181351 -
Flags: review?(mconnor)
Updated•20 years ago
|
Attachment #181351 -
Flags: review?(mconnor) → review+
Comment 30•20 years ago
|
||
Comment on attachment 181351 [details] [diff] [review]
patch for trunk
a=mkaply
Attachment #181351 -
Flags: approval-aviary1.1a+
Assignee | ||
Comment 31•20 years ago
|
||
checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Comment 32•6 years ago
|
||
Keywords: sec508
You need to log in
before you can comment on or make changes to this bug.
Description
•