Closed Bug 220913 Opened 21 years ago Closed 21 years ago

SMTP account panel's port field sometimes changed

Categories

(SeaMonkey :: MailNews: Account Configuration, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ch.ey, Assigned: ch.ey)

Details

Attachments

(1 file)

The Patch for 135357 introduced a new behaviour for the port field. I discovered a rare problem with the UI now I apparently didn't test before. When switching from nonSSL to SSL and vice versa selectProtocol() sets the port to the new protocols default value except any non default port was entered. But I overlooked that this function is also called when the panel is opened. So if you open it with 465 and nonSSL or port 25 and SSL in the prefs, selectProtocol() will overwrite it with 25 in case of nonSSL and 465 in case of SSL. That's because the function thinks you just changed between nonSSL and SSL. Additionally the port is set from 465 to 25 when changing between "Never", "TLS, if available" and "TLS" when port was 465. I know these cases are very rare, but should nevertheless be fixed.
Attached patch proposed patch (deleted) — Splinter Review
I now introduced a new var indicating whether the function was called from init or not. And another one to tell if the default changed. That makes the if() quite complicated but the UI more consistent.
fix checked in, r/sr=bienvenu
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: