User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030914 Firebird/0.6.1+ Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20030925 The CIDR IP network/mask format for entering IP networks in the "No Proxy For" box of the Preferences -> Advanced -> Proxies window (as implemented and described in Bug 80918) does not appear to be documented in the help page. Reproducible: Always Steps to Reproduce: 1. Open preferences 2. Navigate to Advanced -> Proxies 3. Click Help Actual Results: Help says "Type the domains that you do not want to use a proxy for. Separate each domain with a comma. (Example: .yourcompany.com, .yourcompany.co.nz)" Expected Results: Help should say "Type the domains and/or IP networks that you do not want to use a proxy for. Separate each entry with a comma. (Example: .yourcompany.com, .yourcompany.co.nz, 192.168.1.0/24). It would also make sense to change the example displayed on the Proxies preference page itself. xpfe/components/prefwindow/resources/locale/en-US/pref-proxies.dtd browser/components/prefwindow/locale/pref-connection.dtd (don't forget Firebird!) <!ENTITY noproxyExplain.label "Example: .mozilla.org, .net.nz, 192.168.1.0/24">

This implements the proposed change to the Example shown in the Prefs->Proxies page.

Same change for the Options->Connections panel in Firebird

Daniel. The point is that IP networks must be specified as network/mask. Something like 192.168.* will not work (the wildcard notation is accepted by IE, and is often expected to work in Mozilla - hence the reason for wanting it documented correctly).

Oops. Wrong wording in previous attempt. s/domain /entry /

Comment on attachment 133281 [details] [diff] [review] patch for Help content (corrected wording) > IP networks that you do not want Change this to IP address

s/networks/address/ as requested.

Comment on attachment 133285 [details] [diff] [review] patch for Help content r=rlk I'll get this checked in soon.

-> isarnell

Patch checked in.

Keller, did you also check in the first two patches, which deal with: browser/components/prefwindow/locale/pref-connection.dtd xpfe/components/prefwindow/resources/locale/en-US/pref-proxies.dtd ?

Mike, can you take QA for Firebird and see if you can get review.

v

Comment on attachment 133274 [details] [diff] [review] proposed change to example in GUI Not sure sr= was needed, seems not, as the bug was resolved. /be

Iain, it looks like there is a slight typo in the IP in the Firefox patch but if you fixed that you could request review from Mike since he is now reviewing this sort of thing for Firefox. It'd definitely by nice to get this in since this is a fairly commonly asked question over at MZF. (Looks like the Seamonkey version got review but still needs checking as well for that matter.)

Fixed the typo.

Okay, patch for firefox updated per pike's request in comment 15. Bug reopenned. Can we check in the patches for the change to the prefs panels?

Comment on attachment 150645 [details] [diff] [review] proposed change to example in GUI (for Firefox) this is going to either break weird or orphan bits, based on the default size of the dialog. Maybe drop the .net.nz bit.

Mike, I specifically tested it to be sure that it fits the window. At least on Windows XP, no matter what resolution or system font size I use, it always fits.

I would have liked to have this for mozilla 1.7, had I known about it. Please let me know if there is anything I can do to help.

Ben, for Mozilla, I think all that's needed is for the first patch to be checked in. I can't do this myself... (same goes for the Firefox patch).

*** Bug 248476 has been marked as a duplicate of this bug. ***

adding keyword so I check this in later :)

if the seamonkey patch still needs to land, just say so and I'll get it in as well. (What's one more checkin?) The Firefox patch is on branch and trunk.

Mike, yes the patch still needs to go in for seamonkey - could you please.

Shouldn't this go into the HELP component?

This is fixed..., probably a long time ago ;)

V/fixed. I'm looking at at all the current release right now (FF 3.0.1, FF 2.0.0.16, TB 2.0.0.16, SM 1.0.11