User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.6a) Gecko/20031016 Camino/0.7+ Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.6a) Gecko/20031016 Camino/0.7+ The font in "http://netcity5.web.hinet.net/UserData/hoow/html/topics.htm" disobey the Minimum Font Size setted in the Preferences for "Tradtitional Chinese" if "Traditional Chinese (Big5 HKSCS)" encoding is choosen instead of "Traditional Chinese (Big5)". Those characters are too small to read without enlarging the font size. Reproducible: Always Steps to Reproduce: 1. Set the minimum Font Size of "Traditional Chinese" to "24" 2. Open the url "http://netcity5.web.hinet.net/UserData/hoow/html/topics.htm" 3. select View Menu->Text Encoding->Traditional Chinese (Big5 HKSCS) 4. Select View Menu->Text Encoding->Traditional Chinese (Big5) Actual Results: The characters shown in Step 3 is extremely small which disobey the Minimum Font Size setting. The characters shown in Step 4 seem to obey the Minimum Font Size setting. Expected Results: Both Step 3 and 4 should show the same result as obeying the Minimum Font Size setting.

The symptom described in comment #0 is different from what I expected. What I expected is : - The minimum font size setting for TC (Hong Kong) is NOT effective on TC (Hong Kong) page. - Instead, the minimum font size setting for TC (Taiwan) is effective BOTH on TC (Taiwan) page and TC(Hong Kong) page. If the minimum font size setting for TC (Hong Kong) IS effective on TC(Hong Kong) page. Then, there's no bug to fix.

Thanks, Jungshik! However, there isn't a Minimum font size setting for "Traditional Chinese (Hong Kong)" in Camino. There is just a single entry for Tradtional Chinese. Therefore, it should apply to all the possible Traditional Chinese encoding settings. Thanks for your clarification! As the Font setting in Tradtional Chinese applies to both Big5 and Big5-HKSCS, it is logical for minimum font size to apply to both as well. Please help. It should be easy to fix.

> However, there isn't a Minimum font size setting for "Traditional Chinese (Hong > Kong)" in Camino. So, there is not Edit | Pref | Appearance | Font | TC (Hong Kong), either, in Camino 1.6a, is there? To pinkerton: Excuse me for my ignorance on Camino. Does it use /browser and /toolkit instead of /xpfe (just like firebird does)? Then, it's my mistake to forget to ask for landing attacahment 129423 (for bug 152264). (I can't commit to /browser and /toolkit). I'll ask for help on IRC. To Janus: thanks for catching it.

camino uses small parts of xpfe, and nothing from browser or toolkit.

Thanks for the reply. I've just downloaded camino/ and searched for 'zh' and 'Chinese' there. I don't know whether this will work or not. pinkerton, what should I do to add a langGroup(zh-HK in this case, but I found x-devanagari and tamil added to Mozilla a while ago are also missing in Camino) to the font selection menu of Camino?

7 months passed since the original post. Is the patch going to be apply? Strangely, an unofficial build with new tab in Camino 0.8b since have fixed this bug. http://forums.mozillazine.org/viewtopic.php?t=74516&sid=0e5ce69b6c2f65e165e77ff9286e7e77

> Is the patch going to be apply? Nobody set the review flags for this patch, so no-one has know to look at it. If it's ready for review, the review request flag should be set.

Thanks Stuart. Could you tell me how to set the flag? Or how to request a review? I think the patch should work but I haven't tried.

Comment on attachment 134909 [details] [diff] [review] a possible patch this changes the indices in the region mapping so the menu's nib gets out of sync with the mapping r-

Not every patch is for review and I haven't asked for review because I had very little idea how Camino works here. Instead, I asked for help. Anyway, what's the proper way to add new langGroups to the font selection menu of Camino? As I wrote,Camino's font selection menu has been out of sync with other mozilla products for a year or so by now.

The URL in this bug doesn't work for me. Is the report in comment #6 accurate - is this bug fixed already? It would be great if somebody could add a new URL that demonstrates that the problem exists in current builds. Otherwise this bug needs to get marked WORKSFORME.

(In reply to comment #11) > Otherwise this bug needs to get marked WORKSFORME. Does it really work for you? That is, does Camino have a separate font preference for zh-HK like other mozilla products?

referring to comment #11 and #12, I was the one making comment #6. And the answer to your question is "NO, it doesn't". I was confused at that moment. I have found a way to edit the Big5-HKSCS font settings. It is adding settings to user.js file. I did that and it works fine. What need to do is adding an item to the language menu of Camino and names it as "Traditional Chinese (Hong Kong)". I have uploaded my user.js find for reference.

referring to comment #11 and #12, I was the one making comment #6. And the answer to your question is "NO, it doesn't". I was confused at that moment. I have found a way to edit the Big5-HKSCS font settings. It is adding settings to user.js file. I did that and it works fine. What need to do is adding an item to the language menu of Camino and names it as "Traditional Chinese (Hong Kong)". I have uploaded my user.js find for reference.

Any plan on adding zh_hk font setting group?

Sorry for sounds like pushy. I think the patch works. Any plan on landing this patch?

(In reply to comment #9) > (From update of attachment 134909 [details] [diff] [review] [edit]) > this changes the indices in the region mapping so the menu's nib gets out of > sync with the mapping Can you tell me how to sync the menu's nib with the mapping? I took a look at nib files in camino/PreferencePanes/Appearance, but failed to figure that out.

I fixed Camino's font prefs to show Traditional Chinese (Hong Kong). I didn't change any prefs files, because it's not obvious what default font we want. Leaving bug open for default font.

-> 1.0

ok, what default font do we want here?

There are just 2 build-in fonts that include HKSCS. Their names listed in Font Book are "LiHei Pro" and "LiSong Pro". Thanks a ton, Pink!

(In reply to comment #21) > Their names listed in Font Book are "LiHei Pro" and "LiSong Pro". Remember that Gecko needs the Carbon names. These are the current defaults: http://lxr.mozilla.org/mozilla/source/modules/libpref/src/init/all.js#1392

Ok, the names listed in pref.js are as following: serif: "LiSong Pro" san-serif: "LiHei Pro" Does it help?

(In reply to comment #23) > Ok, the names listed in pref.js are as following: > > serif: "LiSong Pro" > san-serif: "LiHei Pro" Those are the Cocoa names, which Camino's font prefs use because of bug 175651; you need to use Camino Extra Fonts (or Fx) to set fonts if you want to get the Carbon names out of prefs.js :-) user_pref("font.name.sans-serif.zh-HK", "儷黑 Pro"); user_pref("font.name.serif.zh-HK", "儷宋 Pro"); What font should be set for Monospace? I can whip up a patch for this with that info.

(In reply to comment #24) > What font should be set for Monospace? > > I can whip up a patch for this with that info. Thanks for getting the legitimate names. :) Unfortunately, Mac OS X currently misses a monospace font for Chinese, both Simplified and Traditional. Moreover, these 2 fonts the only fonts that carry HKSCS. I would suggest 儷黑 Pro as monospace font for the time being.

As this touches Core stuff, not sure who to ask for reviews...jshin, mano? (both did reviews in bug 159809)

Comment on attachment 197001 [details] [diff] [review] New zh-HK defaults as discussed in comments 23-25 Per IRC conversation with Josh, requesting r/sr from jshin/pink respectively.

are these fonts available on all OS versions? Did the names stay consistent between jaguar/panther/tiger?

As I recall, 儷黒 Pro and 儷宋 Pro are added into OS X since 10.3. Though Mac OS X is capable of displaying HKSCS since 10.0 (or even earlier but I haven't tried DP's) provided suitable fonts installed, none of the fonts shipped with OS X included HKSCS until 10.3. My memory may fails me. However, I think we don't have to worry about previous OS X compatibility since we can't have a default setting that works on them for sure. About the names, the display names are consistent as either 儷黒 Pro and 儷宋 Pro, or LiHei Pro and LiSung Pro in menus. I don't know what is the rules for determining Chinese names or English one are display. Both may appear in a single applications, e.g. MSWord shows both. I am not sure about the carbon names though. Note. Please switch the encoding to UTF-8 for showing those characters correctly.

These came first with 10.3. Per the decision in bug 159809 comment 73, we (Mozilla.org) already set as a default for Roman-based langGroups a font that appears first in 10.3. I assume the names stay constant on 10.4--otherwise it would break user documents--but someone on 10.4 should check. We have three choices: 1) stick with current default, which is a font that users must first discover needs to be downloaded and then installed on all versions of Mac OS X 2) use only fonts installed on 10.2, which don't support HKCS 3) use the fonts in this patch, which makes people happy on 10.3 and 10.4 out of the box I think option 3 provides the greatest benefit to the greatest number of people, and 10.2.x users won't be any worse off than they are currently.

Comment on attachment 197001 [details] [diff] [review] New zh-HK defaults as discussed in comments 23-25 i can't formally sr, but it looks good, (s)r=pink. still would like to have jshin look at it too.

I'll take a look at this coming Sunday. Sorry for the delay.

Comment on attachment 197001 [details] [diff] [review] New zh-HK defaults as discussed in comments 23-25 jshin, do you think you will you be able to look at this in the next few days (it's just a Mac font pref change)? It would be nice to get this in before 1.8b5/1.5b2. Thanks.

Comment on attachment 197001 [details] [diff] [review] New zh-HK defaults as discussed in comments 23-25 sorry for the delay. r=jshin asking for a1.8b5. this is a trivial pref. change as mentioned earlier by others

Comment on attachment 197001 [details] [diff] [review] New zh-HK defaults as discussed in comments 23-25 Now that there are reviews and approval, can someone (Simon?) please check this in before the tree closes in a couple days? Thanks.

fixed both on trunk and branch (1.8)