Closed
Bug 226218
Opened 21 years ago
Closed 16 years ago
64bit safe code for mozilla/widget (AMD64)
Categories
(Core :: Widget: Win32, enhancement)
Tracking
()
RESOLVED
FIXED
People
(Reporter: m_kato, Assigned: m_kato)
References
Details
(Keywords: intl)
Attachments
(1 file, 5 obsolete files)
|
(deleted),
patch
|
emaijala+moz
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.6b) Gecko/20031119
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.6b) Gecko/20031119
Currently code isn't considered Windows 64 bits Platform such as Windwos XP 64
bits for AMD64. So we need support it.
- XP Widget should not use GetWindowLong / SetWindowLong. Becasue these aren't
64 bits safe. So you should use GetWindowsLongPtr / SetWindowLongPtr.
Also, Windows 95 / Windows NT 4.0 and later support these functions.
Reproducible: Always
Steps to Reproduce:
Not need. This is build issue.
Actual Results:
Not need. This is build issue.
Expected Results:
Not need. This is build issue.
|
Assignee | |
Comment 1•21 years ago
|
||
|
||
Comment 2•21 years ago
|
||
XP Toolkit is for XUL widgets....
Component: XP Toolkit/Widgets → GFX: Win32
|
||
Updated•21 years ago
|
Flags: blocking1.8a?
|
||
Updated•20 years ago
|
Flags: blocking1.8a? → blocking1.8a-
|
||
Comment 4•20 years ago
|
||
The patch looks fine. I'll try it on 32bit Win2k to make sure. Once we resolve
bug 239279, we don't need this. However, in the meantime, this is necessary.
|
|
||
Comment 5•20 years ago
|
||
adding a couple more to cc for a potential NT 3.5x issue
Status: NEW → ASSIGNED
|
||
Comment 6•20 years ago
|
||
I wasn't able to find GetWindowLongPtrA exported by name on Win32, does it get
renamed by the linker?
>+ DWORD tempStyle = nsToolkit::mGetWindowLongPtr(hwnd, GWL_STYLE);
>+ DWORD tempExStyle = nsToolkit::mGetWindowLongPtr(hwnd, GWL_EXSTYLE);
Question: are DWORDs 64-bit on 64-bit platforms?
(In reply to comment #6)
> I wasn't able to find GetWindowLongPtrA exported by name on Win32, does it get
> renamed by the linker?
GetWindowLongPtrA/W is defined as GetWindowLongA/W on 32-bit windows. It only
exists as a distinct function on 64-bit platforms. See the extract from the
header file towards the end of this page:
http://forum.hardware.fr/hardwarefr/Programmation/sujet-50765-1.htm
|
|
Assignee | |
Comment 8•19 years ago
|
||
|
|
Assignee | |
Updated•19 years ago
|
Attachment #213149 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 9•19 years ago
|
||
Attachment #135925 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 10•19 years ago
|
||
Attachment #213150 -
Attachment is obsolete: true
|
||
Comment 11•18 years ago
|
||
Is this going to be fixed soon?
|
||
Comment 12•18 years ago
|
||
Makoto: What is the status of your patch? Is it bitrotten? If not, why not ask for a review?
|
|
Assignee | |
Comment 13•18 years ago
|
||
I have a new fix for current code, But I don't test this code on x86 compiler due to source compatibilities.
I will add patch and send this to code review.
|
||
Updated•17 years ago
|
Whiteboard: [helpwanted]
|
|
Assignee | |
Comment 14•16 years ago
|
||
Assignee: jshin1987 → m_kato
Attachment #213151 -
Attachment is obsolete: true
Attachment #326161 -
Flags: superreview?(emaijala)
Attachment #326161 -
Flags: review?(emaijala)
|
||
Comment 15•16 years ago
|
||
Comment on attachment 326161 [details] [diff] [review]
a patch
I'm not a superreviewer.
Is there a reason for changing GWL_STYLE and GWL_EXSTYLE calls to DWORD_PTR? As far as I know the change is only necessary for pointers and handles.
Attachment #326161 -
Flags: superreview?(emaijala)
|
|
||
Comment 16•16 years ago
|
||
Comment on attachment 326161 [details] [diff] [review]
a patch
Well, I guess it doesn't hurt. At least then the safe one is used consistently.
Attachment #326161 -
Flags: review?(emaijala) → review+
|
|
Assignee | |
Updated•16 years ago
|
Blocks: tracking_win64
|
|
Assignee | |
Updated•16 years ago
|
Assignee: m_kato → nobody
Component: XUL → Widget
QA Contact: ian → general
Hardware: x86 → x86_64
Whiteboard: [helpwanted]
|
|
Assignee | |
Comment 17•16 years ago
|
||
Assignee: nobody → m_kato
Attachment #326161 -
Attachment is obsolete: true
Attachment #356451 -
Flags: review?(emaijala)
|
|
||
Updated•16 years ago
|
Attachment #356451 -
Flags: review?(emaijala) → review+
|
|
Assignee | |
Comment 18•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Component: Widget → Widget: Win32
QA Contact: general → win32
You need to log in
before you can comment on or make changes to this bug.
Description
•