Closed
Bug 227745
Opened 21 years ago
Closed 18 years ago
search plugin dropmarker doesn't match default theme
Categories
(Firefox :: Toolbars and Customization, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: glc_bugs, Unassigned)
Details
(Keywords: polish)
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031207 Firebird/0.7+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031207 Firebird/0.7+
The search dropmarker should look similar to the default back and forward
dropmarkers: centered vertically and separated from the icon horizontally. The
current marker is at the baseline and slightly overlapping the icon.
Reproducible: Always
Steps to Reproduce:
This dropmarker should (possibly) be themeable so that the look can match any
installed theme.
Updated•21 years ago
|
Assignee: hyatt → bugs
Status: UNCONFIRMED → NEW
Ever confirmed: true
this is pretty easily fixed. not sure if there's a reason it was put
half-overlapping the icon to start with. so the question is: was there a
reason/should it be changed?
as for themeability - it already is. pretty much everything is. but it's up to
the theme makers to customize it. several themes have already corrected this.
tho it would definitely jack up themes, another idea would be to make the search
icon into a menu-type button with a separate dropmarker. you could use the
dropmarker to select the engine from the popup, then click the icon itself to
trigger the search. then you wouldn't need a separate "search" button for
mouse-clickers.
dropmarker clears the right edge of the search icon, and is vertically
centered.
but noticed something else while figuring this out: the search bar looks like
**** in the palette.
Reporter | ||
Updated•21 years ago
|
Flags: blocking1.0?
Updated•21 years ago
|
Flags: blocking1.0? → blocking1.0-
Reporter | ||
Comment 3•20 years ago
|
||
someone should probably review the patch. If it works (and it looks good to me),
it would make good polish for 1.0.
Keywords: polish
Reporter | ||
Updated•20 years ago
|
Whiteboard: [have patch]
Reporter | ||
Comment 4•19 years ago
|
||
On second glance... margin: 3px 0 4px 16px; looks a little better centered with
the current image. And shouldn't it be .searchbar-dropmarker-image?
Also, to match the default theme, the dropdown arrow should be smaller (like the
ones for back and forward).
I think I'll CC Kevin Gerich on this one.
Updated•19 years ago
|
Assignee: bugs → nobody
QA Contact: bugzilla → toolbars
Reporter | ||
Comment 5•19 years ago
|
||
Changes tracked in bug 335435, particularly bug 335441, may also fix this bug.
Reporter | ||
Comment 6•18 years ago
|
||
This appears to be fixed by the visual refresh for Firefox 2 (bug 345407). At least it looks right in the last couple nightlies.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [have patch]
You need to log in
before you can comment on or make changes to this bug.
Description
•