Closed
Bug 229211
Opened 21 years ago
Closed 17 years ago
Remove: browser.related.enabled (because it is ignored)
Categories
(SeaMonkey :: Preferences, defect, P2)
SeaMonkey
Preferences
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.8alpha1
People
(Reporter: benc, Assigned: benc)
References
()
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
(I don't know much about this feature...)
lxr doesn't seem to show code that looks at this, and flipping it on and off via
about:config did not seem to affect the behavior of "what's related".
Apparently, there was a pref panel selection for this feature, which was removed:
http://bugzilla.mozilla.org/show_bug.cgi?id=29915#c4
I'll remove these prefs for either 1.6f (unlikely), or 1.7-based trunk.
I have a bunch of other stale prefs I need to remove that relate to networking.
Assignee: general → benc
Summary: browser.related.enabled ignored → Remove: browser.related.enabled (because it is ignored)
/browser/app/profile/firefox.js, line 117
/calendar/sunbird/app/profile/all.js, line 194
/mail/app/profile/thunderbird.js, line 180
/xpfe/bootstrap/browser-prefs.js, line 118
The main products can be fixed via 205077. Patch for xpfe coming up.
Attachment #143987 -
Flags: review?
Comment on attachment 143987 [details] [diff] [review]
removes pref
Darin has approved removal from the trunk. Asa is also aware of these updates
related to "what's related".
Attachment #143987 -
Flags: review? → review?(bsmedberg-mozilla)
The trunk was patched before 1.7f branch, the rest will have to wait.
Component: Browser-General → Preferences
Priority: -- → P2
Target Milestone: --- → mozilla1.8alpha
The whole document looks old, but I'm just going to fix this section.
Comment on attachment 145930 [details] [diff] [review]
updates documentation
wrong bug. ingore.
Attachment #145930 -
Attachment is obsolete: true
Updated•20 years ago
|
Product: Browser → Seamonkey
Comment 8•19 years ago
|
||
Removes unused pref
Attachment #143987 -
Attachment is obsolete: true
Attachment #201317 -
Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #201317 -
Flags: review?(neil.parkwaycc.co.uk)
Attachment #143987 -
Flags: review?(bsmedberg)
Comment 9•19 years ago
|
||
Comment on attachment 201317 [details] [diff] [review]
Updated patch
Although I don't see how the old patch could have bitrotted...
Attachment #201317 -
Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #201317 -
Flags: superreview+
Attachment #201317 -
Flags: review?(neil.parkwaycc.co.uk)
Attachment #201317 -
Flags: review+
Comment 10•19 years ago
|
||
Checked in.
Thanks for driving this home, Frank!
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 11•19 years ago
|
||
REOPEN (ugh).
/browser/app/profile/firefox.js, line 249 -- pref("browser.related.enabled", true);
/js/tests/e4x/Regress/regress-308111.js, line 632 -- <pref><name>browser.related.enabled</name></pref>
/mail/app/profile/all-thunderbird.js, line 370 -- pref("browser.related.enabled", true);
I guess some files forked before the trunk checkin...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 12•18 years ago
|
||
"You tried to change the Product field from Mozilla Application Suite to Firefox but only the assignee or reporter of the bug, or a sufficiently empowered user may change that field."
Still seeing this on Firefox 1.5.0.7.
Comment 13•17 years ago
|
||
> /browser/app/profile/firefox.js, line 249 -- pref("browser.related.enabled",
> true);
> /js/tests/e4x/Regress/regress-308111.js, line 632 --
> <pref><name>browser.related.enabled</name></pref>
> /mail/app/profile/all-thunderbird.js, line 370 --
> pref("browser.related.enabled", true);
>
> I guess some files forked before the trunk checkin...
This bug is targeted at the Suite, not Firefox etc., and you took their issue to bug 205077 in comment #2, so what's the point of reopening this bug?
Suggesting restoring FIXED.
Comment 14•17 years ago
|
||
Resolving as per comment #13. If you REOPEN, please describe in detail how to reproduce on SeaMonkey 2.0a1pre, preferably with a User-Agent string, as pasted from the about: page and similar to
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008040701 SeaMonkey/2.0a1pre
Status: REOPENED → RESOLVED
Closed: 19 years ago → 17 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 15•16 years ago
|
||
Karsten: that was because there is no component that you can use to target an old pref in core that got forked to all the products, and I don't think we need a bunch of one-line per product bugs.
Anyhow, LXR shows that someone was kind enough to remove the remaining lines.
FYI, Tony, there is no way to reproduce this bug at the level you describe. It's a code tree bug...
Status: RESOLVED → VERIFIED
Comment 16•16 years ago
|
||
Ah, sorry. T'was just a boilerplate comment anyway, which I usually add when closing old bugs which seem to be "in need of closing but forgotten", just in case the bug (any bug in that category) pops up again somewhere, maybe in a Branch build. It doesn't mean I understand the details of the bug.
You need to log in
before you can comment on or make changes to this bug.
Description
•