nsViewBeOS call in mozilla/widget/src/beos/nsWindow.h is inherited from both BView and nsIWidgetStore, but object which uses this class is declared in sme header file as BView *mView; which causes several casts and additional methods like BView *CreateBeOSView(); Wondering why not to use just nsViewBeOS instead BView, and thus to have not only direct access to cached mWidget, but also to cache nsToolkit - see bug http://bugzilla.mozilla.org/show_bug.cgi?id=226889

Not an _XP_ widgets issue.... that component is for cross-platform widgets.

bz, do components in mozilla/widget really belong to GFX:* ?

sergei: they don't, but they're labeled beos. in the future there may be a widget: beos. in the meantime, just live with the slight misnomer. it's much easier for me and everyone else to send port bugs here.

Time to fix that, it seems, as we started to use more and more nsViewBeOS methods

review request

Comment on attachment 201998 [details] [diff] [review] patch. r=thesuckiestemail@yahoo.se (It seems I do more reviewing than coding :)

checked in trunk: Checking in mozilla/widget/src/beos/nsWindow.cpp; /cvsroot/mozilla/widget/src/beos/nsWindow.cpp,v <-- nsWindow.cpp new revision: 1.108; previous revision: 1.107 done Checking in mozilla/widget/src/beos/nsWindow.h; /cvsroot/mozilla/widget/src/beos/nsWindow.h,v <-- nsWindow.h new revision: 1.45; previous revision: 1.44 done. Attention to Nielx - further changes may depend on that, so it is good to fix it at branch too at some moment

I'll keep track of it.

Will be backported to the MoZILLA_1_8_BRANCH

Comment on attachment 201998 [details] [diff] [review] patch. Requesting approval for the MOZILLA_1_8_BRANCH. This is a BeOS-only change and will not affect any other platforms. Note to sergei_d: apply after bug 315208

Enter passphrase for key '/boot/home/.ssh/id_dsa': Checking in mozilla/widget/src/beos/nsWindow.cpp; /cvsroot/mozilla/widget/src/beos/nsWindow.cpp,v <-- nsWindow.cpp new revision: 1.91.4.16; previous revision: 1.91.4.15 done Checking in mozilla/widget/src/beos/nsWindow.h; /cvsroot/mozilla/widget/src/beos/nsWindow.h,v <-- nsWindow.h new revision: 1.35.4.11; previous revision: 1.35.4.10 done