Closed
Bug 229866
Opened 21 years ago
Closed 21 years ago
Turn off non-virtual destructor warnings
Categories
(SeaMonkey :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bryner, Assigned: bryner)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
With the compiler flags we use, gcc issues a warning in many cases if you define
a class that has virtual functions but does not have a virtual destructor. This
causes bogus warnings (quite a few, with another patch I'm working on), and in
general isn't useful for most of the code in our tree.
Some classes probably unnecessarily define virtual destructors just to quiet the
compiler, too... a virtual destructor is only needed if your object could be
deleted through a base class pointer.
|
Assignee | |
Comment 1•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Attachment #138263 -
Flags: review?(dbaron)
|
||
Comment 2•21 years ago
|
||
Comment on attachment 138263 [details] [diff] [review]
patch
r=dbaron. See also the discussion in bug 113192.
Attachment #138263 -
Flags: review?(dbaron) → review+
|
|
Assignee | |
Comment 3•21 years ago
|
||
checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Comment 4•21 years ago
|
||
This patch got rid of 15 "'class xxx' has virtual functions but non-virtual
destructor" 'Blamed Build Warnings; Linux brad Clobber' :-)
Blocks: buildwarning
Severity: normal → trivial
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•