Closed Bug 230173 Opened 21 years ago Closed 21 years ago

Mozilla use 15 point size font for characters with style {font-size:14px;}

Categories

(Core Graveyard :: GFX: Gtk, defect)

Sun
SunOS
defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Ervin.Yan, Assigned: blizzard)

References

Details

Attachments

(1 file)

User-Agent: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.4) Gecko/20031229 Build Identifier: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.4) Gecko/20031229 Mozilla use 15 point size font for characters with style {font-size:14px;} for example, visit webpage http://news.sina.com.cn you will see some lines are wrapped. that is because mozilla use 15 point size font for the Chinese characters with style {font-size:14px;} Reproducible: Always Steps to Reproduce: 1. 2. 3. Expected Results: should use 14 point size font for style {font-size:14px;}
Attached patch use float type for mPointSize (deleted) — Splinter Review
If use PRUint16 type for mPointSize, for 14px style characters, mPointSize became 11, while convert back to the true font size, it become 15 point size. but if use float type for mPointSize, for 14px style characters, mPointSize became 10.5, and remain 14 point size when convert back to the true font size.
Comment on attachment 138463 [details] [diff] [review] use float type for mPointSize r=blizzard This seems pretty reasonable.
Attachment #138463 - Flags: review+
Blocks: xft_tracking
Status: UNCONFIRMED → NEW
Ever confirmed: true
blizzard: could you also give sr?
Attachment #138463 - Flags: superreview+
patch checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Viewing this site with the following font settings Sans-Serif: Verdana: 13 point Monospace: LucidaTypewriter 12 point on a clobber build of MozillaFirebird on Redhat 9 with GTK2 http://forums.mozillazine.org/viewforum.php?f=32 I see a difference in rendering in the hyperlink of the username in the "Last post" column. It seems much smaller than before This also shows up in the Slashdot boxes (on the right hand side) which aggregate RSS feeds from other sites. If I revert the changes as suggested by bonsai, then the rendering occurs as before
I suspect this is going to result in some different rendering. Whether or not it's also incorrect is another issue.
tor on irc said that post-checkin he felt the fonts bigger, I feel the opposite it maybe that whilst tor mentions he has a minimum font size, my setting for minimum font size is "None"
Using an 2004-01-14 XFT/GTK2 build, I'm seeing smaller font rendering as compared to an 2004-01-08 XFT/GTK2 build. I'm seeing this not only on the site that Yusuf mentioned, but on pretty much any site (including cnn.com, mozilla.org). The fonts just appear generally smaller across the board. I tested by opening the above two copies of Firebird using different profiles and browsing the same websites. When switching between windows, the 2003-01-14 build had obviously smaller fonts. I don't know if this is corrent or incorrect rendering, but this is what I'm seeing. FWIW, I'm using Fedora Core 1. Maybe we should reopen this to examine carefully what's going on.
Flags: blocking1.7a?
I think this increased pageload time a bit for xft: http://axolotl.mozilla.org/graph/query.cgi?testname=pageload&tbox=redwood&autoscale=1&days=7&avg=1&showpoint=2004:01:15:03:07:23,993 shows a pageload spike about the time this went in that isn't present on any non-xft tinderbox.
See also bug 197037 comment 29: Assuming that using pixels instead of points would let us go back to integer maths, that should speed this up too, right?
I think it is OK to add the following settings in unix.js, pref("font.min-size.variable.x-western", 10); pref("font.min-size.fixed.x-western", 10); so that Mozilla show English characters OK for small font size.
Flags: blocking1.7a?
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: