Steps to reproduce: 1. Load the testcase. 2. Ctrl+Shift+R to load it again with the image not cached. Result: After step 3, the link doesn't unwrap. Alternate steps to reproduce: 1. Load the testcase. 2. Ctrl+R (so it doesn't wrap). 3. Resize the window to be very narrow. 4. Resize the window to be normal-sized. Result: the link wraps (between the :before image and the link) Expected: the link should not wrap, because there's plenty of room Regression window (tested first set of steps with various Firebird builds): good: 01/08 mozjf broken: 01/10 scragz broken: 01/13 mozjf I discovered this bug by loading http://www.cs.hmc.edu/~jruderma/s/ (my start page) with a user style sheet that adds http://mozilla.org/images/mozilla-16.png before every link to mozilla.org.

possible checkins: http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=01%2F08%2F2004+00%3A00%3A00&maxdate=01%2F08%2F2004+23%3A00%3A00&cvsroot=%2Fcvsroot

I can narrow the range to between 2004-01-08-07 and 2004-01-09-09. Bernd, are you sure the regression couldn't be after a Jan 8 evening build? If so, the most likely culprit is bug 118117. Otherwise, it could also be bug 190735.... Of course this could also be bug 210001, I guess.

the regression can onlybe narrowed between the 2004-01-08-09 and 2004-01-09-09 build (to early in the morning for me :-) http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=01%2F08%2F2004+07%3A00%3A00&maxdate=01%2F09%2F2004+09%3A00%3A00&cvsroot=%2Fcvsroot

It isn't 118117, I tried backing it out and that didn't help.

No need for :before. This testcase shows the problem too. I tried backing out bug 210001 locally and that did not help either.

roc, this is all you. See http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/layout/html/base/src&command=DIFF_FRAMESET&file=nsBlockFrame.cpp&rev1=3.597&rev2=3.598&root=/cvsroot the last hunk. I did NOT review that change, and undoing it fixes this bug.

Comment on attachment 139292 [details] [diff] [review] Patch roc, would you review?

I think accidentally checked in his suggestion on bug 229052.

Comment on attachment 139292 [details] [diff] [review] Patch Yoikes! My bad! sorry sorry.

Fixed.