Closed Bug 23237 Opened 25 years ago Closed 25 years ago

Fix all of the base classes that don't have a specifier

Categories

(Core Graveyard :: Tracking, defect, P3)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: jdunn, Assigned: jdunn)

References

Details

Attachments

(1 file)

There are lots of classes that specify a base class but don't indicate whether it is public or private. AIX assumes that it is private, but I am not sure if that is a good assumption. My intention is to list all of them here and mark them 'public'. I will also copy everyone who owns one of the files.
Blocks: 18688
Status: NEW → ASSIGNED
Target Milestone: M13
"nsPSMDetectors.cpp", line 321.7: 1540-001: (W) "private" assumed for base class "nsPSMDetector". "nsPSMDetectors.cpp", line 392.7: 1540-001: (W) "private" assumed for base class "nsPSMDetector". "xpctest_inout.cpp", line 39.22: 1540-001: (W) "private" assumed for base class "nsIXPCTestInOut". "xpctest_multiple.cpp", line 172.48: 1540-001: (W) "private" assumed for base class "nsIXPCTestParentOne". "xpctest_multiple.cpp", line 172.69: 1540-001: (W) "private" assumed for base class "nsIXPCTestParentTwo". "xpctest_multiple.cpp", line 394.48: 1540-001: (W) "private" assumed for base class "xpcTestParentOne". "xpctest_multiple.cpp", line 394.66: 1540-001: (W) "private" assumed for base class "xpcTestParentTwo". "xpctest_multiple.cpp", line 464.48: 1540-001: (W) "private" assumed for base class "xpcTestParentTwo". "../../dist/include/nsCertificatePrincipal.h", line 35.64: 1540-001: (W) "private" assumed for base class "nsBasePrincipal". "../../dist/include/nsCodebasePrincipal.h", line 37.53: 1540-001: (W) "private" assumed for base class "nsICodebasePrincipal". "../../dist/include/nsCodebasePrincipal.h", line 37.53: 1540-001: (W) "private" assumed for base class "nsICodebasePrincipal". "../../dist/include/nsCodebasePrincipal.h", line 37.53: 1540-001: (W) "private" assumed for base class "nsICodebasePrincipal". "../../dist/include/nsCodebasePrincipal.h", line 37.53: 1540-001: (W) "private" assumed for base class "nsICodebasePrincipal". "nsSliderFrame.h", line 51.30: 1540-001: (W) "private" assumed for base class "nsIDOMMouseListener". "nsSliderFrame.h", line 52.30: 1540-001: (W) "private" assumed for base class "nsIAnonymousContentCreator". "nsSliderFrame.h", line 53.30: 1540-001: (W) "private" assumed for base class "nsITimerCallback". "nsScrollbarFrame.cpp", line 51.47: 1540-001: (W) "private" assumed for base class "nsIStyledContent". "nsScrollbarFrame.cpp", line 51.65: 1540-001: (W) "private" assumed for base class "nsIAnonymousContent". "nsSliderFrame.h", line 51.30: 1540-001: (W) "private" assumed for base class "nsIDOMMouseListener". "nsSliderFrame.h", line 52.30: 1540-001: (W) "private" assumed for base class "nsIAnonymousContentCreator". "nsSliderFrame.h", line 53.30: 1540-001: (W) "private" assumed for base class "nsITimerCallback". "nsRDFDOMViewerUtils.h", line 29.27: 1540-001: (W) "private" assumed for base class "nsIRDFDOMViewerObject". "nsRDFDOMResourceFactory.h", line 33.31: 1540-001: (W) "private" assumed for base class "nsRDFResource". "nsRDFDOMResourceFactory.h", line 34.31: 1540-001: (W) "private" assumed for base class "nsIDOMViewerElement". "nsRDFDOMViewerUtils.h", line 29.27: 1540-001: (W) "private" assumed for base class "nsIRDFDOMViewerObject". "nsInternetSearchService.cpp", line 215.59: 1540-001: (W) "private" assumed for base class "nsIStreamListener". "nsMsgWindow.h", line 36.42: 1540-001: (W) "private" assumed for base class "nsIURIContentListener". "nsMimeBaseEmitter.h", line 67.50: 1540-001: (W) "private" assumed for base class "nsIPipeObserver". "nsSmtpService.cpp", line 222.25: 1540-001: (W) "private" assumed for base class "nsIChannel". "nsMsgComposeService.h", line 28.58: 1540-001: (W) "private" assumed for base class "nsIContentHandler". "TestXPTCInvoke.cpp", line 478.20: 1540-001: (W) "private" assumed for base class "FooImpl". "TestXPTCInvoke.cpp", line 478.29: 1540-001: (W) "private" assumed for base class "BarImpl".
I am getting back lots of okays... r= warren@netscape.com r= jband@netscape.com
Attached patch Proposed Fix (deleted) — Splinter Review
r= ftang@netscape.com for intl/chardet/src/nsPSMDetectors.cpp line 321 & 392. they are private!
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Checked in on 1/10. if this stuff builds... I would say it is QA'd!
Adding verifyme keyword.
Keywords: verifyme
Status: RESOLVED → VERIFIED
marking verified
Keywords: verifyme
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: