Closed
Bug 233082
Opened 21 years ago
Closed 19 years ago
default value of browser.display.screen_resolution is wrong
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
People
(Reporter: dbaron, Assigned: dbaron)
Details
(Keywords: fixed1.8.1, Whiteboard: [patch])
Attachments
(1 file)
(deleted),
patch
|
roc
:
review+
roc
:
superreview+
benjamin
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
The default value of the browser.display.screen_resolution is wrong. It was
supposed to be -1 (meaning max(96dpi, system setting)), but it somehow got set
to 0 (meaning system setting). This can make pages with point-specified font
sizes unreadable on systems with a system setting considerably under 96dpi
(e.g., 75dpi).
Gerv broke this in his patch for bug 81904.
I think the prefs dialog should have a name for -1 -- I'm tempted to use "Best".
Comment 1•21 years ago
|
||
"Optimal"?
Comment 2•21 years ago
|
||
"meaning max(96dpi, system setting)"
What is it supposed to be when the system setting is in fact greater than 96?
Either? Greater of? Smaller of?
Assignee | ||
Comment 3•21 years ago
|
||
max() is a common notation for a function that returns the larger of its two
arguments. I meant, use the system's idea of DPI if larger than 96dpi,
otherwise use 96dpi. This prevents fonts specified in pt from being too small.
Assignee | ||
Comment 4•19 years ago
|
||
This doesn't matter as much these days, since Xft's default is 96 instead of the old X 75, but we still don't want to use less than 96 for people who configure Xft that way (Fedora has UI for it), since it makes some Web pages illegibly small.
Attachment #208927 -
Flags: superreview?(roc)
Attachment #208927 -
Flags: review?(roc)
Assignee | ||
Updated•19 years ago
|
Whiteboard: [patch]
Attachment #208927 -
Flags: superreview?(roc)
Attachment #208927 -
Flags: superreview+
Attachment #208927 -
Flags: review?(roc)
Attachment #208927 -
Flags: review+
Assignee | ||
Comment 5•19 years ago
|
||
Checked in to trunk.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•19 years ago
|
Attachment #208927 -
Flags: approval1.8.1?
Updated•19 years ago
|
Attachment #208927 -
Flags: approval1.8.1? → branch-1.8.1+
You need to log in
before you can comment on or make changes to this bug.
Description
•