Closed Bug 233094 Opened 21 years ago Closed 21 years ago

[FIXr]input text doesn't appear in text box if text box is in floated cell

Categories

(Core :: Layout: Tables, defect, P2)

Product:
Core
Component:
Layout: Tables
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.7final

People

(Reporter: james.d.baker, Assigned: bzbarsky)

References

(
URL
)

Details

(Keywords: fixed1.7, testcase)

Attachments

(4 files)

Minimal testcase
(deleted), text/html
Details
Eviler testcase
(deleted), text/html
Details
Even eviler testcase
(deleted), text/html
Details
This fixes all three testcases and the website
(deleted), patch
dbaron
: review+
dbaron
: superreview+
chofmann
: approval1.7+
Details | Diff | Splinter Review
User-Agent: Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040113 I have a page with a search (input) box in a table cell. This cell has a background image which is set via CSS. When I click in the text box, the cursor doesn't show up. I tried typing and I found that the text appeared to the left over the top of a different cell. Note: The URL may be taken down soon. Reproducible: Always Steps to Reproduce: 1. Goto page 2. Click in search box and type 3. Text appears up and to the left Actual Results: The text appeared in the wrong place, and over the top of everything else Expected Results: The text should have appeared in the input box
Attached file Minimal testcase (deleted) —
roc, would misparented views cause this?
Attached file Eviler testcase (deleted) —
Summary: input text doesn't appear in text box if text box is in cell with a background image → input text doesn't appear in text box if text box is in floated cell
Attached file Even eviler testcase (deleted) —
The basic idea is that when we construct the pseudo cell we need to make it the float containing block.... This is a little fragile, though -- there may be other codepaths that could produce pseudo cells. It really would be better if we could keep track of this in the frame constructor state somehow... perhaps mPseudoFrames could push the floater block when it creates the anonymous table cell and pop it when ProcessPseudoFrames is called or something? But that can introduce nesting issues with other pushes....
Assignee: nobody → bzbarsky
Status: UNCONFIRMED → ASSIGNED
Component: Layout: Form Controls → Layout: Tables
OS: Windows XP → All
Priority: -- → P2
QA Contact: core.layout.form-controls → core.layout.tables
Hardware: PC → All
Summary: input text doesn't appear in text box if text box is in floated cell → [FIX]input text doesn't appear in text box if text box is in floated cell
Target Milestone: --- → mozilla1.7alpha
Comment on attachment 140654 [details] [diff] [review] This fixes all three testcases and the website David, what do you think?
Attachment #140654 - Flags: superreview?(dbaron)
Attachment #140654 - Flags: review?(dbaron)
Keywords: testcase
Blocks: 233276
Blocks: 234561
No longer blocks: 234561
Blocks: 235120
Blocks: 237458
Blocks: 237718
Blocks: 233720
Blocks: 232581
Comment on attachment 140654 [details] [diff] [review] This fixes all three testcases and the website I'm not crazy about any of the table pseudo frame construction code, and I don't remember my previous objection to this patch, but r+sr=dbaron.
Attachment #140654 - Flags: superreview?(dbaron)
Attachment #140654 - Flags: superreview+
Attachment #140654 - Flags: review?(dbaron)
Attachment #140654 - Flags: review+
> I'm not crazy about any of the table pseudo frame construction code I'm not either.... I have some ideas on nuking all of it and replacing it with something sane, but they're not to the point where I can coherently describe them yet...
Summary: [FIX]input text doesn't appear in text box if text box is in floated cell → [FIXr]input text doesn't appear in text box if text box is in floated cell
Target Milestone: mozilla1.7alpha → mozilla1.8alpha
Checked in for 1.8a trunk.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
It might be worth requesting 1.7 approval for this.
Comment on attachment 140654 [details] [diff] [review] This fixes all three testcases and the website Hmm.. yeah, this fixes issues with all sorts of sites, and should be reasonably safe. I've been running with this patch for a while now, with no ill effects that I have seen.
Attachment #140654 - Flags: approval1.7?
Comment on attachment 140654 [details] [diff] [review] This fixes all three testcases and the website a=chofmann 1.7
Attachment #140654 - Flags: approval1.7? → approval1.7+
Checked in on the branch.
Keywords: fixed1.7
Target Milestone: mozilla1.8alpha → mozilla1.7final
*** Bug 218672 has been marked as a duplicate of this bug. ***
*** Bug 242101 has been marked as a duplicate of this bug. ***
Blocks: 57513
Note: this caused crash bug 263846.
Checked in some reftests for this.
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: