Closed Bug 233292 Opened 21 years ago Closed 21 years ago

remove "empty damage rect" warning in nsFrame::Invalidate

Categories

(Core :: Layout, defect, P3)

Product:
Core
Component:
Layout
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.7alpha

People

(Reporter: dbaron, Assigned: dbaron)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [patch])

Attachments

(1 file)

patch
(deleted), patch
roc
: review+
roc
: superreview+
Details | Diff | Splinter Review
I think the "empty damage rect" warning is silly. Function call overhead isn't that high, and the code for checking emptiness could easily be in both places or just inside nsFrame::Invalidate. Furthermore, the flow of control shouldn't be different in DEBUG and non-DEBUG builds.
Attached patch patch (deleted) — — Splinter Review
Also use const in a few places to get rid of DEBUG-only warnings.
Attachment #140755 - Flags: superreview?(roc)
Attachment #140755 - Flags: review?(roc)
Status: NEW → ASSIGNED
Priority: -- → P3
Whiteboard: [patch]
Target Milestone: --- → mozilla1.7alpha
Comment on attachment 140755 [details] [diff] [review] patch Hear hear! The code should definitely be in the callee, not the caller, because there are always more callers than callees
Attachment #140755 - Flags: superreview?(roc)
Attachment #140755 - Flags: superreview+
Attachment #140755 - Flags: review?(roc)
Attachment #140755 - Flags: review+
Fix checked in 2004-02-06 15:11 -0800.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
We have a lot of callers that _do_ check the emptiness of the rect... should those checks be removed as convenient?
It doesn't matter to me.
Product: Core → Core Graveyard
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: