Closed
Bug 233480
Opened 21 years ago
Closed 21 years ago
weird things happen when root is 'display: inline'
Categories
(Core :: Layout: Block and Inline, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla1.7alpha
People
(Reporter: dbaron, Assigned: dbaron)
References
()
Details
(Whiteboard: [patch])
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
The fact that my patch to bug 229654 regressed the centering in the testcase in
bug 229654 (attachment 140880 [details]) suggests that something is broken when the root
is inline. Probably the best fix is to fix up the computed style data according
to the fixups for the root element in CSS2.1 9.2.4 rather than doing the fixup
in ConstructRootFrame.
|
Assignee | |
Comment 1•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Attachment #140919 -
Flags: superreview?(bzbarsky)
Attachment #140919 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Updated•21 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [patch]
Target Milestone: --- → mozilla1.7alpha
|
|
Assignee | |
Comment 2•21 years ago
|
||
A little more cleanup of GetUniqueStyleData
Attachment #140919 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•21 years ago
|
Attachment #140919 -
Flags: superreview?(bzbarsky)
Attachment #140919 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Updated•21 years ago
|
Attachment #140920 -
Flags: superreview?(bzbarsky)
Attachment #140920 -
Flags: review?(bzbarsky)
|
||
Comment 3•21 years ago
|
||
Comment on attachment 140920 [details] [diff] [review]
patch
Could you remove the aPresContext arg of GetUniqueStyleData while you're here?
r+sr=bzbarsky with that.
Attachment #140920 -
Flags: superreview?(bzbarsky)
Attachment #140920 -
Flags: superreview+
Attachment #140920 -
Flags: review?(bzbarsky)
Attachment #140920 -
Flags: review+
|
|
Assignee | |
Comment 4•21 years ago
|
||
Attachment #140920 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•21 years ago
|
||
Fix checked in to trunk, 2004-02-08 22:55/56 -0800.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•