Closed
Bug 235277
Opened 21 years ago
Closed 19 years ago
make go button look like other toolbar buttons
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
Firefox 2 alpha1
People
(Reporter: miahzmiahz+bmo, Assigned: miahzmiahz+bmo)
References
Details
(Keywords: fixed1.8.1, polish)
Attachments
(2 files, 1 obsolete file)
(deleted),
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
(deleted),
image/png
|
Details |
User-Agent:
Build Identifier:
bug 187096 suggests that the go button should "physically" be like other toolbar
buttons. but until then, the current go button can be styled with CSS to look
like the other toolbar buttons in the default theme.
Reproducible: Always
Steps to Reproduce:
this, along with the patch for bug 225088 (go button in icon/text modes),
should have the go button looking and behaving like a normal toolbar button. a
slight hack was necessary since there's no large mode go icon. so in large
mode, the button is vertically centered in the toolbar. all other modes and
states appear as expected.
this also includes a fix for the right-click hover issue mentioned in bug
187096 comment #3
setting this blocking1.0=?
patch needs to be updated since the new theme - the concept still applies. i'll
cook one up as soon as i get this new install of 0.9 up and running.
Keywords: polish
Shouldn't this be marked as invalid now since a new theme is being used?
Comment 4•20 years ago
|
||
(In reply to comment #3)
> Shouldn't this be marked as invalid now since a new theme is being used?
read comment 2
Updated•20 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Somewhere along the way the Go Button was changed from a "button" to a
"toolbarbutton" so that simplified things a bit - other than that, same effect
as previous patch. This makes the button fill the height of the toolbar like
other normal buttons instead of being a fixed height. This breaks convention
with IE's Go, but i think it's appropriate since our Go can be placed anywhere
- not just immediately following the address bar. It also adjusts the label
spacing to that it stays centered and a little more balanced inside the button.
Attachment #142022 -
Attachment is obsolete: true
Updated•19 years ago
|
Assignee: bugs → nobody
QA Contact: bugzilla → toolbars
Updated•19 years ago
|
Attachment #161813 -
Flags: review+
Updated•19 years ago
|
Assignee: nobody → miahzmiahz+bmo
OS: Windows 2000 → All
Hardware: PC → All
Comment 7•19 years ago
|
||
mozilla/browser/themes/winstripe/browser/browser.css; new revision: 1.25;
and on the 1.8 branch:
mozilla/browser/themes/winstripe/browser/browser.css; new revision: 1.17.2.12;
Status: NEW → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Target Milestone: --- → Firefox 2 alpha1
You need to log in
before you can comment on or make changes to this bug.
Description
•