Closed Bug 236545 Opened 21 years ago Closed 21 years ago

Proportional scrollbars assume pageincrement == slider height

Categories

(Core :: XUL, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

Details

Attachments

(2 files)

The proportional scrollbar thumb calculation code bases the size of the thumb on the slider size rather than the pageincrement attribute. This makes custom ranges harder to use because of the proportional display scaling calculation.
Attached file Test case (deleted) —
Because the pageIncrement is 20% of the maxpos I expect the thumb to take up 20% of the space, but in fact what happens is that the slider takes up an amount of space roughly equal to the maxpos.
Attached patch Proposed patch (deleted) — Splinter Review
Assignee: jag → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED
Attachment #142996 - Flags: review?(roc)
Comment on attachment 142996 [details] [diff] [review] Proposed patch Looks good to me.
Attachment #142996 - Flags: superreview+
Attachment #142996 - Flags: review?(roc)
Attachment #142996 - Flags: review+
Fix checked in, thanks!
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: