Closed
Bug 236545
Opened 21 years ago
Closed 21 years ago
Proportional scrollbars assume pageincrement == slider height
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
Details
Attachments
(2 files)
(deleted),
application/vnd.mozilla.xul+xml
|
Details | |
(deleted),
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
The proportional scrollbar thumb calculation code bases the size of the thumb on
the slider size rather than the pageincrement attribute. This makes custom
ranges harder to use because of the proportional display scaling calculation.
Assignee | ||
Comment 1•21 years ago
|
||
Because the pageIncrement is 20% of the maxpos I expect the thumb to take up
20% of the space, but in fact what happens is that the slider takes up an
amount of space roughly equal to the maxpos.
Assignee | ||
Comment 2•21 years ago
|
||
Assignee: jag → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED
Assignee | ||
Updated•21 years ago
|
Attachment #142996 -
Flags: review?(roc)
Comment on attachment 142996 [details] [diff] [review]
Proposed patch
Looks good to me.
Attachment #142996 -
Flags: superreview+
Attachment #142996 -
Flags: review?(roc)
Attachment #142996 -
Flags: review+
Assignee | ||
Comment 4•21 years ago
|
||
Fix checked in, thanks!
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•