Closed Bug 237610 Opened 21 years ago Closed 17 years ago

Can't cancel "master password" dialog (repeats forever)

Categories

(Core Graveyard :: Security: UI, defect)

Product:
Core Graveyard
Component:
Security: UI
Version:
1.0 Branch
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: yuliy.pisetsky, Unassigned)

References

Details

(Whiteboard: [kerh-coz]) 

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040312
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040312

When Mozilla prompts the user to enter the master password, there is no way to
cancel out. Pressing cancel or entering an invalid password pops the modal
dialog box right back up again. Congratulations, mozilla is effectively hung.
Have to use whatever OS method there is to close it and reopen if password
forgotten, for instance

Reproducible: Always
Steps to Reproduce:
1. If master password not set, set it
2. go to tools, password manager, log out
3. Do something which requires the master password (i.e. manage stored passwords)
4. Try and get rid of the dialog without entering correct password

Actual Results:  
Impossible to leave dialog without entering correct password

Expected Results:  
Cancel stops whatever action needed the password to complete, mozilla continues
on as normal
*** Bug 237662 has been marked as a duplicate of this bug. ***
--> PSM
Assignee: dveditz+bmo → kaie
Component: Password Manager → Client Library
Product: Browser → PSM
QA Contact: bmartin
Version: Trunk → unspecified
-> Password Manager
Assignee: kaie → dveditz+bmo
Component: Client Library → Password Manager
Product: PSM → Browser
Version: unspecified → Trunk
Confirming. And shoulkdn't product stay at PSM for product as it also happens in
Mozilla Mail for example?
Status: UNCONFIRMED → NEW
Ever confirmed: true
This is truly annoying... did it come in with NSS 3.9?

Since the password dialog is modal you are completely stuck if you don't know
the password. Example: a guest borrows my computer to check their web-based e-mail.
 1) fire up the browser
 2) surf to the webmail site
--> I also have an account at that site so they get the master password prompt

They are now stuck. Can't get their mail, can't surf elsewhere (it's modal),
can't even close the browser except by killing it. They can only continue if I
enter my password which I'm not too keen to do (think teenage relatives).

If you're stuck because you forgot your master PW then you'd better hope you
don't have prefs set to open and check for new mail at startup because then you
can't even get into the preferences to reset the password before you get stuck
in the loop.

partial workaround: if you know the feature exists--most users don't--you can
create a guest profile.
Assignee: dveditz → kaie
Component: Password Manager → Client Library
Flags: blocking1.7?
Product: Browser → PSM
Version: Trunk → 1.01
Summary: No way to leave a "enter master password" dialog box without entering correct password → Can't cancel "master password" dialog (repeats forever)
Flags: blocking1.7? → blocking1.7+
Strange. I get it again if it I hit cancel, but the second time it goes away.
has anything changed? Seems to be working ok now. (It does repeat the dialog, up
to three times if you enter a bad password, which I assume is on purpose.
Repeating if you cancel is a little odd).

WFM thank goodness -- anyone else?
now it seems to pop up again a random number of times. sometimes it goes away
after 1 or 2 appearances, other times 10+ appearances
I think it might depend on the content. I used the bugzilla page for a test and
looked at the two call stacks.

In one case it was for the HTTP Handler, in the other case it was for the image
loader.

I'll post stacks tomorrow.
This is an old bug - it goes back to at least 1.4.2 and maybe even older builds
(I just downloaded 1.4.2 and gave it a try to make sure). At least it's an old
bug on the Mac.
Flags: blocking1.7+ → blocking1.7-
alright. Now the behavior seems to have flipflopped. Even immediately after
choosing "Password Manager->Log Out" and then going to Manage stored passwords
right after I do that, it does not prompt me, and the display stored passwords
option displays blanks for all of the passwords.
(Build 2004053009 May 30)
*** Bug 244683 has been marked as a duplicate of this bug. ***
*** Bug 268196 has been marked as a duplicate of this bug. ***
hmmm... I think when I filed it, it actually did loop infinitely, but now that
issue is gone. So I guess duping this seems appropriate 
I can no reproduce the bug with current Mozilla 1.7.5 on Linux, when activated
from password manager.

If I cancel, I'm not prompted again.

Is this a platform dependent bug, or is it fixed?

Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7.5) Gecko/20041217

I can reproduce this problem too easily.  

On the menu bar, I selected [Tools > Password Manager > Manage Stored
Passwords].  The input popop appeared, requesting my master password.  I
selected the Cancel button a large number of times without any result.  The
popup remained until I entered my master password and selected the OK button.  I
closed the Password Manager window.  

On the menu bar, I then selected [Tools > Password Manager > Log Out].  I went
to the Mozilla.org Bugzilla login page.  The input popup for my master password
appeared.  I had to select the Cancel button twice to close the popup.  

Note that the behavior is indeed different between what happens when I went to
manage my stored passwords and when I went to a Web site that uses a stored
password.  For the former, the input popup is indefinitely persistent when the
Cancel button is selected.  For the latter, it takes "only" two attempts to
cancel for success.  
> On the menu bar, I selected [Tools > Password Manager > Manage Stored
> Passwords].  The input popop appeared, requesting my master password.  I
> selected the Cancel button a large number of times without any result.  The
> popup remained until I entered my master password and selected the OK button.

I tried this with both Mozilla 1.7.5 and today's trunk.
I get the password prompt, I press cancel, the dialog disappears.

Maybe it's really a platform / windows bug.
I can't help without being able to reproduce, sorry.
Assignee: kaie → nobody
Product: PSM → Core
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.10) Gecko/20050716
Firefox/1.0.6 - Build ID: 2005071605

When having to enter the Master Password to log into a site, I only had to
cancel it once to make it disappear.  However, the same could not be said for
this prompt when viewing saved passwords.

I'm not entirely sure about this, but after messing around with it a bit, the
number of times you need to press "Cancel" to close the "Master Password" dialog
box (when viewing saved passwords) could possibly be related to the number of
username/password combination sets saved.

I have tried this out in three different profiles - two of them have only a few
username/password combination sets (three and four, respectively, with no sites
in "Passwords Never Saved" for both), and the third has 66 username/password
combination sets (with five sites in "Passwords Never Saved").  The first two
took only three and four clicks (respectively) on "Cancel" to close the "Master
Password" dialog box, whereas the third took 41 clicks to close it.
*** Bug 307609 has been marked as a duplicate of this bug. ***
*** Bug 312723 has been marked as a duplicate of this bug. ***
*** Bug 314840 has been marked as a duplicate of this bug. ***
Whiteboard: [kerh-coz]
*** Bug 334060 has been marked as a duplicate of this bug. ***
I have the same problem on Windows 2000 with Firefox 2.0

It's strange to see such trivial problem still open for 2.5 years.
*** Bug 359708 has been marked as a duplicate of this bug. ***
QA Contact: bmartin → ui
isn't this dup of bug 210433?
(In reply to comment #26)
> isn't this dup of bug 210433?

It is, if you ask me. Comments 15 and 16 seem to agree with you, but no-one took action. The other bug is older, has some useful information and even a patch attached but this one has a higher severity and a more general scope (Product: Core) which is think is more correct since I can also see this with Firefox 2.0.0.3 (Windows).
This should be fixed as a result of 381164.
Status: NEW → RESOLVED
Closed: 17 years ago
Depends on: 381164
Resolution: --- → FIXED
Timothy, can you confirm the behavior you were seeing with saved passwords has improved since the fix in bug 381164?
Bill,

I am now using Firefox 2.0.0.12 (instead of Firefox 1.0.6, which was used in my previous message), and this issue appears to be fixed - I can no longer reproduce the behavior I saw in my previous message regarding the "Master Password" dialog.
Version: psm1.01 → 1.0 Branch
I have this issue in Firefox 5.0 and suggest re-opening the bug.
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.