Closed
Bug 237935
Opened 21 years ago
Closed 21 years ago
if anonymous logins fail it doesn't fall back to asking for a username/password
Categories
(Core :: Networking: FTP, defect)
Core
Networking: FTP
Tracking
()
RESOLVED
DUPLICATE
of bug 124561
People
(Reporter: jon787, Assigned: dougt)
References
()
Details
Attachments
(2 obsolete files)
User-Agent: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.6) Gecko/20040209 Firefox/0.8
Build Identifier: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.6) Gecko/20040209 Firefox/0.8
If anonymous FTP login fails it doesn't fall back to asking for a username and
password eventhough the comments in the source code indicate it should.
file: netwerk/protocol/ftp/src/nsFtpConnectionThread.cpp line 1034
// we just tried to login anonymously and failed.
// kick back out to S_user() and try again after
// gathering uname/pwd info from the user.
Reproducible: Always
Steps to Reproduce:
1. Find FTP server that doesn't allow anonymous logins
2. Connect with ftp://server.name/
3. Get rejection
Actual Results:
Error message pops up about anonymous user not existing
Expected Results:
A box asking for a username and password (possibly preceded by the current error
message)
I found a way to fix the problem, might not be the "right" way but it seems to
work.
This is also the first patch I ever contributed back to a project.
Ooops I attached the modified source file instead of the patch :(
Attachment #144282 -
Attachment is obsolete: true
Attachment #144289 -
Attachment is obsolete: true
That patch reopens the old bug that caused this problem in the first place :( oh
well, anyway:
I traced this problem back to the fix for bug 24985.
That involved getting a username/password box if the anonymous FTP login failed
with a "530 Server is full" error. The fix for that was simple checking for 5xx
errors and returning FTP_ERROR from nsFtpState::R_user(). The response code for
"anonymous user unknown" is the exact same number as the "server is full", so
the patch for bug 24985 permanently disabled the fallback to asking for a
username and password.
There has to be a way to determine whether 530 was sent because of
authentication problems or server load.
duplicate of "helpwanted" bug 124561
*** This bug has been marked as a duplicate of 124561 ***
Status: UNCONFIRMED → RESOLVED
Closed: 21 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•