nsIMIMEInfo should use interCaps like all other interfaces.

Comment on attachment 147986 [details] [diff] [review] patch bz, this should be a simple review... but if you don't have time or if if you don't want to do reviews or something, I can ask darin for r+sr instead

Comment on attachment 147986 [details] [diff] [review] patch r=bzbarsky, assuming you didn't miss any callers. ;) I love how we have 3 identical copies of everything...

(In reply to comment #3) > (From update of attachment 147986 [details] [diff] [review]) > r=bzbarsky, assuming you didn't miss any callers. ;) I do hope I got all of them :) I really hate how JS makes it impossible to do this kind of checking at compiletime...

Comment on attachment 147986 [details] [diff] [review] patch sr=darin I wonder how many third-party extensions this is going to break :-(

well, we'll need to break them anyway on the road to libxul (by which point we should have this frozen, imo).

Agreed. This interface is definitely something we should try to freeze for libxul if not for 1.8 =)

before freezing this, we should decide something about the other dependencies of bug 162116; especially the one about non-ascii extensions. it may be sufficient to use AUTF8String for the extension attributes here... (interface-wise) I'll send an announcement of this change to newsgroups and mozillazine forums... hopefully that'll suffice we should have some process to announce such changes, methinks...

checked in.

looks like the browser/ part needs relanding

the toolkit/ part too, for that matter

biesi: send mail to ben goodger?? or are you going to take care of re-landing it?

darin: my impression was that someone would go through the bugs with the aviary-landing keyword and check those in again...

ok, makes sense.

Relanding relevant parts of patch following aviary branch landing One difference: - var desc = mimeInfo.Description; + var desc = mimeInfo.description; instead of - aFilePicker.appendFilter(mimeInfo.Description, extString); + aFilePicker.appendFilter(mimeInfo.description, extString);