Closed Bug 239714 Opened 21 years ago Closed 20 years ago

Address books not alphabetical in main address book window

Categories

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: beitmanh, Assigned: Bienvenu)

Details

(Keywords: fixed-aviary1.0, regression)

Attachments

(1 file)

User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.0.0) Gecko/20020530 Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.0.0) Gecko/20020530 After upgrading to Mozilla 1.7b from 1.6 my address book window shows the list of address books, but they are not sorted alphabetically. In fact, they seem randomly listed, beginning in the P's, but not going in order from there. The list was fine under 1.6. Reproducible: Always Steps to Reproduce: 1.Open Address Book from main e-mail window 2.Review list of address books shown 3.Names in the address books are shown in alphabetical order Actual Results: Address books not in alphabetical order Expected Results: Te books should be listed in alphabetical order, but there does not seem to be a way to sort the books (can sort their entries).
I'm using Mozilla/5.0 (Windows; U; Windows NT 5.0; de-AT; rv:1.7) Gecko/20040506 and I can confirm this bug.
I'm using Mozilla/5.0 (Windows; U; Windows NT 5.0; de-AT; rv:1.8a1) Gecko/20040520 and I can still confirm this bug.
Flags: blocking1.8a2+
Flags: blocking1.7.1+
Confirming based on comments and a quick inspection (though listing the "Personal" address book first may be as-designed, the other appear out of order too). Changing blocking flags to blocking nominations... only drivers@mozilla.org get to turn nominations ("?") into blockers ("+")
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking1.8a2?
Flags: blocking1.8a2+
Flags: blocking1.7.1?
Flags: blocking1.7.1+
Anyone know what change regressed this? /be
Adding regression keyword due to discription and newsgroup discussion.
Keywords: regression
yes, probably because we now sort by position, which allows you to arbitrarily sort address books. However, if you haven't set the per dir position pref, the sort order should be like it was before. The only way I can imagine the position pref could get set is if you migrated from 4.x
H. Beitman confirmed his profile came from 4.x, which confirms my suspicion. Here's what I recommend: If you shutdown Mozilla, and then edit your prefs.js by hand, you can remove the .position prefs for your address book (just search for lines with .position and remove the ones that are setting a position for an address book), and then restart. Or you can use about:config in Moz to remove the prefs. I don't believe this is a serious bug, since I believe we should be sorting like 4.x did, by position, and presumably, the 4.x order had some sort of meaning...it's just that for a long time we were ignoring the position prefs
Flags: blocking1.8a2? → blocking1.8a2-
My profile isn't form 4.x I built it by Netscape 7.1. Who decided to change the sort function like this? Is there a bug on which somebody wanted this change? I can't see a reason why address books now should be sorted by position and not any more alphabetically! For me, it isn't a problem to remove the .position prefs for my address books. But if I create a new one, I have to edit prefs.js again. For a normal Mozilla user it's too difficult and too elaborately to do this by themselves. In my company we are using about 15en different address books and I can't always change all the prefs.js for them. So, please activate alphabetically sorted by 1.72 and 1.8 final again. Like it was by Mozilla 1.6 By the way, what did you mean with "However, if you haven't set the per dir position pref, the sort order should be like it was before."? Is this a point at the prefs.js too? If it is, May this point should be at the address book menu. So everybody can choose how the address books should by sorted, by positions or alphabetically!
Flags: blocking1.8a2- → blocking1.8a2?
(In reply to comment #8) Why did you change 'blocking1.8a2' from '-' to '?' ? It's surprising since v1.8a2 was released "today". (What is yet missing is a 'blocking1.8a3' flag...)
I'm missing a 'blocking 1.8a3' or 'blocking 1.8b1' too. That's the reason I choose 1.8a2! ;-)(In reply to comment #9)
(In reply to comment #10) > I'm missing a 'blocking 1.8a3' or 'blocking 1.8b1' too. That's the reason I > choose 1.8a2! ;-) I do understand ... but this is a wrong thing to do: please set it back to '-'. (and wait for the new flag to come...)
The intent was that new address books would not get position set, so the sort would not be affected - but it looks like position is getting set for new AB's, despite reports that new AB's were not affected by the sort. The intent was that only MCD or users could set position, or users upgrading from 4.x. I'll try to fix it so that position is not set for new AB's, but you'll still have to clear it out for AB's created since position started getting set automatically.
(In reply to comment #12) That sounds fine to me. But I think a lot of other Mozilla users, which aren't very familiar with this prefs.js, would be happy, if there would be a menu point to choose how the address books should be sorted. You can set the position # to every address book but there should be flag which said that Mozilla has to ignore this position #. If this flag is set, it'd automatically sort the AB's alphabetically.
Flags: blocking1.8a2? → blocking1.8a2-
(In reply to comment #12) > I'll try to fix it so that position is not set for new AB's Did you notice bug 249613 which could be +/- related ?
Flags: blocking-aviary1.0?
Flags: blocking1.8a3?
Flags: blocking1.8a3? → blocking1.8a3-
plussing after talking to David about this.
Flags: blocking-aviary1.0? → blocking-aviary1.0+
Flags: blocking1.8a3-
Flags: blocking1.8a2-
taking. I'm going to try to fix it so that new AB's do not get their position set, so they'll sort normally...
Assignee: sspitzer → bienvenu
Attached patch proposed fix (deleted) — Splinter Review
set position to kDefaultPosition for new ab's, not count. This won't help users who have already added AB's, but they can go remove the positions from prefs.js...
Attachment #161280 - Flags: superreview?(mscott)
Attachment #161280 - Flags: superreview?(mscott) → superreview+
Status: NEW → RESOLVED
Closed: 20 years ago
Keywords: fixed-aviary1.0
Resolution: --- → FIXED
Hi David Thank you very, very match for implementing this solution. It works fine. Thanks again!
Product: Browser → Seamonkey
1.7.5 has shipped. Moving request to 1.7.6.
Flags: blocking1.7.5? → blocking1.7.6?
Not in the scope of the 1.7.6 release
Flags: blocking1.7.6? → blocking1.7.6-
OS: Windows XP → All
Hardware: PC → All
I just downloaded the nightly build (2-16-05) and installed it. To my suprise the address book feature is not sorting NEW address books alphabetically. I added an address book and it was placed at the end of my list of books, right after "Collected Addresses" which has appeared last since around version 1.4 if memory serves me. Closing down Mozilla and bringing it back up does nothing to change the problem. It was a mid-alphabet letter, so it should have been placed roughly in the middle of the list, not the end. I think this is pretty similar to the issue I orginally brought up, so I am adding this note to the bug. The original issue had to do with the existing books not being sorted alphabetically, but new ones were placed in the proper order. In fact, you could fix the problem by creating all new address books which would then be in proper order. Not sure what happened now, but adding a NEW address book did not seem to be a problem before. The entries within the address books are sorted properly!
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: