Closed Bug 240175 Opened 21 years ago Closed 20 years ago

{inc}page sometimes too wide due to marquee tag inside table (phpBB scrolling panel)

Categories

(Core :: Layout: Tables, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: p.quaedackers, Unassigned)

References

()

Details

Attachments

(4 files)

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7b) Gecko/20040316 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7b) Gecko/20040316 On the site www.luvstruck.com I've noticed that the page isn't showed how it should be shown. Some cells are to wide, witch results in scrolling horizontal note: this is a new bug filed on a request in bug 217369. Reproducible: Sometimes Steps to Reproduce: 1. go to www.luvstruck.com (use build id 2004031616 / mozilla 1.7 beta) 2. look at the weblayout Actual Results: Sometimes the page is displayed to wide. Some cells don't have the correct width Expected Results: page should display in the center of the page page is sometimes to wide and you have to scroll right to see the rest of the site
Please have a look at http://weblogs.mozillazine.org/hyatt/archives/2003_08.html#003963 the bug can be seen in this frame: http://www.luvstruck.com/forum/portal.php I suppose the loading of the images may be slow, as they are genreated via external java script which writes the url via document.write http://www.kortingswinkel.nl/images/banners/120X60.gif http://www.datik.be:8080/afterthehype/datik_button/120x88_B.gif <table width="800" cellspacing="0" cellpadding="10" border="0" align="center"> <TR> <td class="bodyline"> <table width="100%" cellspacing="0" cellpadding="0" border="0" align="center"> <tr><td valign="top" width="23%"> <table width="100%" cellspacing="1" cellpadding="1" border="0" align="left"> <tr><td> <table width="100%" cellpadding="2" cellspacing="1" border="0" class="forumline"> <tr><td class="catHead" height="25"><span class="genmed"><b> Sponsors</b></span></td></tr> <tr><td class="row1" align="left"><span class="genmed" style="line-height: 150%"></span> <table width="120" border="0" align="center"> <tr><td><script language="JavaScript" src="http://impnl.tradedoubler.com/imp/pool/js/13513/666071" charset="ISO-8859-1"></script></td></tr></table> 666071 loads: document.write('<a href="http://tracker.tradedoubler.com/click?p=17098&a=666071&g=147580" target="_blank"><img border="0" src="http://www.datik.be:8080/afterthehype/datik_button/120x88_B.gif"></a>') so this is a rather slow way to genrate the images, and the blog tells that stalled scripts can give these type of errors.
(In reply to comment #1) <<CUTTED TEXT>> > so this is a rather slow way to genrate the images, and the blog tells that > stalled scripts can give these type of errors. > That could explain why I can't get the error to re-occour. Is this something that should be fixed?
if the page display inconsistently, then there is a bug somewhere in Mozilla and it should be fixed. But I'm not able to reproduce the problem you're seeing. A testcase would help to get this bug fixed.
Summary: page displays to wide due to bad table(cell) width → {inc}page displays to wide due to bad table(cell) width
(In reply to comment #3) > if the page display inconsistently, then there is a bug somewhere in Mozilla and > it should be fixed. But I'm not able to reproduce the problem you're seeing. > > A testcase would help to get this bug fixed. I did my test on this bug with a 333 MHz Celeron, 96 MB RAM, swapping harddisks, ISDN connection 64 kbit, slower, while downloading a nightly. I shortly tried the page on an Athlon XP 1600, 512 MB, 768 kbit DSL, and couldn´t reproduce it.
I think this is happening because of the marquee tag. I will attach a reproducable testcase. I think this caused the same problem at http://www.vragenforum.nl/ (is fixed now, see http://forums.mozillazine.org/viewtopic.php?t=84429&highlight=)
I put '<script>var x=document.body.offsetHeight;</script>' just after the marquee tag. The page was only stripped from its img and iframe tags.
Also using Hyatt's hack.
The marquee code seems to be a module of the phpBB system, so this could happen on all sites which have the marquee module activated in their phpBB system. Bug 238808 is probably the same bug, but this one has a testcase (I did see that one after I attached the testcases here).
Status: UNCONFIRMED → NEW
Component: Layout → Layout: Tables
Ever confirmed: true
Summary: {inc}page displays to wide due to bad table(cell) width → {inc}page sometimes too wide due to marquee tag inside table (phpBB scrolling panel)
Blocks: 238808
*** Bug 238808 has been marked as a duplicate of this bug. ***
(I've not read all the comments...) Could this be related to the issue in bug 207340 comment 5 ?
This bug has been affecting firefox for several weeks now (cvs builds). Through 2004-09-17. <MARQUEE> is full size of window. See posts in threads at http://www.cobbs.ca/ where people have participated in the Arcade. With Firefox the Arcade scroller is full length of the screen, even when the marquee is specified to be 120px wide. While in Mozilla the behavior is correct. This is on an LFS box with X.Org 6.8.1
the patch in bug 234593 fixes the marquee cases, but not the last testcase with -moz-box.
Depends on: 234593
Attached file testcase with mozbox (deleted) —
Martijn, I dont see how the -moz-box testcase is related to the marquee thingie. If one specifies left and righ margin to be 100% it should overflow. So the "broken" (correct) behaviour can be seen without the layout breakpoint. The picture in this testcase does not change even with a layout breakpoint between the cells. So I believe that the fix for bug 234593 will completely fix this issue.
As far as I can remember it, I was trying to make a testcase without the use of <marquee>, but with the elements (and style rules), that were added by the marquee binding. Clearly, I didn't succeed. My testcase was wrong, your patch is right.
Martijn, could you please look again at this bug it should be fixed now that the patch for bug 234593 got checked in
Yep, seems fixed now :) I tested it with a 2004-10-30 trunk (1.8a) build. Great work!
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: