Closed
Bug 240408
Opened 21 years ago
Closed 20 years ago
Allow browser to handle <embed> content
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
People
(Reporter: tor, Assigned: tor)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
jst
:
superreview+
|
Details | Diff | Splinter Review |
We should allow the browser to handle the content of <embed> frames
as we do for <object>. This would allow a mozilla with native SVG
to handle the SVG content of pages that were written for use with
a plugin.
URL: hixie,alex@croczilla
Comment 2•20 years ago
|
||
Comment on attachment 146016 [details] [diff] [review]
allow browser to handle <embed> content
Nice! :-)
sr=jst
Attachment #146016 -
Flags: superreview+
Comment 3•20 years ago
|
||
*** Bug 231171 has been marked as a duplicate of this bug. ***
Attachment #146016 -
Flags: review?(dbaron)
Comment 4•20 years ago
|
||
This seems like it would make EMBED work with text/html too, which I don't think
we want to do.
Also, are people really using EMBED for plugin SVG content, rather than OBJECT?
The Adobe SVG demos, the Adobe "SVG Site Spotlight", and the W3C's SVG
test suite all are using <embed>.
Why would an embed of text/html be a bad thing? A roundabout way of
doing an iframe, but doesn't seem harmful.
Comment 6•20 years ago
|
||
Using the 'object' tag to embed SVG in web pages crashes Safari 1.0, so I have
been forced to switch to using 'embed' [1]. Since updates to Safari are not
available to users of Mac OS X version 10.2, I have to assume Safari 1.0 will be
in circulation for some years to come.
[1]: http://www.alleged.org.uk/pdc/2004/02/14.html
For some reason, almost all browsers have had disastrously buggy implementations
of 'object' at some point; Safari is merely the most recent. As a result,
'embed' is a lot more prevelant than the W3C would have liked.
Comment 7•20 years ago
|
||
I don't think we should be adding additional capabilities to deprecated features
of HTML if nobody wants them, since it just encourages use of the deprecated
features.
Comment 8•20 years ago
|
||
Comment on attachment 146016 [details] [diff] [review]
allow browser to handle <embed> content
review- per comment 7
Attachment #146016 -
Flags: review?(dbaron) → review-
Comment 9•20 years ago
|
||
dbaron: Would it make you feel better if we put <embed> into a whatwg.org spec
and said it was no longer deprecated?
Comment 10•20 years ago
|
||
Some standard-conscious people are forced to use 'embed' because MS IE refuses
to 'render' the following straightforward construct using 'object' complaining
about 'insecure' content being fed to ActiveX control.
<object data="test.mp3" type="audio/mpeg" height="239" width="45">
You are expected to listen to ..... </object>
To avoid that, one has to use a construct like this:
<object id="Player" CLASSID="CLSID:6BF52A52-394A-11d3-B153-00C04F79FAA6"
width="239" height="45" title="Playing Music">
<param name="URL" value="music.mp3" />
<param name="autoStart" value="true" />
<embed src="music.mp3" type="application/x-mplayer2"
width="239" height="45"
pluginspage = "http://www.microsoft.com/Windows/MediaPlayer/">
<noembed>Music to be played</noembed>
</object>
Again, those caring about the standard compliance would love to use 'object' in
place of 'embed', but MS IE does NOT ignore the inner 'object' and complain
about 'the security' although it should just ignore it because it can process
the outer object.
Comment 11•20 years ago
|
||
What does that have to do with this bug? This bug is about objects that would
be handled by Mozilla itself (like, say, text/html objects).
Assignee | ||
Comment 12•20 years ago
|
||
Attachment #164791 -
Flags: superreview?(jst)
Attachment #164791 -
Flags: review?(dbaron)
Comment 13•20 years ago
|
||
Comment on attachment 164791 [details] [diff] [review]
only allow handing of svg <embed>
>+#ifndef MOZ_SVG
> // only do the following for the object tag
> if (aContent->Tag() != nsHTMLAtoms::object)
> return rv;
>+#endif
Just drop this entirely. It makes things more confusing, and it's not
performance-critical.
Also, while you're there, it looks like IsSupportedImage and
IsSupportedDocument can be static. If that's correct, please make them static
(one less argument passed).
Attachment #164791 -
Flags: review?(dbaron) → review+
Assignee | ||
Comment 14•20 years ago
|
||
Attachment #146016 -
Attachment is obsolete: true
Attachment #164791 -
Attachment is obsolete: true
Attachment #164802 -
Flags: superreview?(jst)
Comment 15•20 years ago
|
||
Comment on attachment 164802 [details] [diff] [review]
adjust per dbaron's review comments
sr=jst
Attachment #164802 -
Flags: superreview?(jst) → superreview+
Updated•20 years ago
|
Attachment #164791 -
Flags: superreview?(jst)
Assignee | ||
Comment 16•20 years ago
|
||
Checking in nsObjectFrame.cpp;
/cvsroot/mozilla/layout/html/base/src/nsObjectFrame.cpp,v <-- nsObjectFrame.cpp
new revision: 1.475; previous revision: 1.474
done
Checking in nsObjectFrame.h;
/cvsroot/mozilla/layout/html/base/src/nsObjectFrame.h,v <-- nsObjectFrame.h
new revision: 1.32; previous revision: 1.31
done
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Core → Core Graveyard
Updated•6 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•