Closed
Bug 240745
Opened 21 years ago
Closed 21 years ago
decomtaminate nsIScriptObjectPrincipal
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: bryner, Assigned: bryner)
Details
Attachments
(1 file)
|
(deleted),
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
This will let us remove the duplicate GetPrincipal() methods on the Document
implementations.
|
Assignee | |
Comment 1•21 years ago
|
||
Probably the most interesting part here is the fix to nsCrypto.cpp. When I was
looking at this code, I found that the braces didn't actually match the
indentation or the way the code is intended to work.
|
|
Assignee | |
Comment 2•21 years ago
|
||
Comment on attachment 146310 [details] [diff] [review]
patch
Also, I think the last change in nsCrypto.cpp plugs a leak.
Attachment #146310 -
Flags: superreview?(jst)
Attachment #146310 -
Flags: review?(jst)
|
||
Comment 3•21 years ago
|
||
Comment on attachment 146310 [details] [diff] [review]
patch
r+sr=jst
Attachment #146310 -
Flags: superreview?(jst)
Attachment #146310 -
Flags: superreview+
Attachment #146310 -
Flags: review?(jst)
Attachment #146310 -
Flags: review+
|
|
Assignee | |
Comment 4•21 years ago
|
||
checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•