Closed
Bug 242495
Opened 21 years ago
Closed 21 years ago
Extension to type mapping broken on Linux
Categories
(Core Graveyard :: File Handling, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: Bienvenu)
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
patch
|
bzbarsky
:
review+
mscott
:
superreview+
|
Details | Diff | Splinter Review |
This is a regression from bug 197166. It looks like the data is never copied
from "cbuf" into "buf" in the loop in
nsOSHelperAppService::GetTypeAndDescriptionFromMimetypesFile -- as a result, we
only ever see the first line of the file.
I suppose the other loops should be checked too, just to make sure.
And of course OS/2 has the same issues.
|
Reporter | |
Updated•21 years ago
|
Keywords: regression
|
Assignee | |
Comment 1•21 years ago
|
||
Whoops, sorry. OS/2 is OK..
|
|
Assignee | |
Updated•21 years ago
|
Attachment #147581 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Updated•21 years ago
|
Attachment #147581 -
Flags: superreview?(mscott)
|
|
Reporter | |
Comment 2•21 years ago
|
||
Comment on attachment 147581 [details] [diff] [review]
proposed fix
r=bzbarsky, I think. Like I said in the other bug, using -p and more context
(-u6 or -u8) would make patches a _lot_ easier to review...
Attachment #147581 -
Flags: review?(bzbarsky) → review+
|
||
Updated•21 years ago
|
Attachment #147581 -
Flags: superreview?(mscott) → superreview+
|
|
Assignee | |
Comment 3•21 years ago
|
||
fixed, thx, I'll try to remember the -p option.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•